Date: Sat, 4 May 2013 07:19:19 +0100 From: Chris Rees <utisoft@gmail.com> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Baptiste Daroussin <bapt@freebsd.org>, ports-committers@freebsd.org Subject: Re: svn commit: r317243 - head/deskutils/menumaker Message-ID: <CADLo83-GA__tf=j%2BqxGp88kZTQbXesG4F4kBmq6oLHwk9n_OHA@mail.gmail.com> In-Reply-To: <20130504050636.GA54091@FreeBSD.org> References: <201305032040.r43KeNIb027043@svn.freebsd.org> <20130504050636.GA54091@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 4 May 2013 06:06, "Alexey Dokuchaev" <danfe@freebsd.org> wrote: > > On Fri, May 03, 2013 at 08:40:23PM +0000, Baptiste Daroussin wrote: > > New Revision: 317243 > > URL: http://svnweb.freebsd.org/changeset/ports/317243 > > > > Log: > > Fix build with bmake > > > > @@ -14,6 +10,7 @@ MAINTAINER= ports@FreeBSD.org > > COMMENT= Menu generator for X Window Managers and desktop environments > > > > USE_PYTHON= yes > > +USE_GMAKE= yes > > Since you decided not to surround it with bmake-specific conditional this > time, I think it would be nice to add a comment instead, e.g.: > > USE_GMAKE=yes # fails with bmake(1) > > I usually try to check periodically why some ports need gmake(1); it would > make it easier for me with such comments, thanks! I prefer the PARSEDIR solution, but however you do it, please be consistent; I want to work on fixing these upstream and need something to grep for! Chris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo83-GA__tf=j%2BqxGp88kZTQbXesG4F4kBmq6oLHwk9n_OHA>