From owner-cvs-src@FreeBSD.ORG Thu Apr 27 16:59:09 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AADD916A400; Thu, 27 Apr 2006 16:59:09 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 160D043D48; Thu, 27 Apr 2006 16:59:06 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [10.10.3.185] ([69.15.205.254]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id k3RGx173001410; Thu, 27 Apr 2006 10:59:03 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <4450F84D.4080601@samsco.org> Date: Thu, 27 Apr 2006 10:58:53 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.12) Gecko/20060206 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Brooks Davis References: <200604261942.k3QJgdnb086990@repoman.freebsd.org> <20060427102026.GC20828@garage.freebsd.pl> <20060427163351.GB12971@odin.ac.hmc.edu> In-Reply-To: <20060427163351.GB12971@odin.ac.hmc.edu> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=0.0 required=3.8 tests=none autolearn=failed version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org Cc: John-Mark Gurney , cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Pawel Jakub Dawidek , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern sched_4bsd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Apr 2006 16:59:09 -0000 Brooks Davis wrote: > On Thu, Apr 27, 2006 at 12:20:26PM +0200, Pawel Jakub Dawidek wrote: > >>On Wed, Apr 26, 2006 at 07:42:39PM +0000, John-Mark Gurney wrote: >>+> jmg 2006-04-26 19:42:38 UTC >>+> >>+> FreeBSD src repository >>+> >>+> Modified files: >>+> sys/kern sched_4bsd.c >>+> Log: >>+> move remaining sysctl into the kern.sched tree... >>[...] >>+> -SYSCTL_INT(_kern, OID_AUTO, ccpu, CTLFLAG_RD, &ccpu, 0, ""); >>+> +SYSCTL_INT(_kern_sched, OID_AUTO, ccpu, CTLFLAG_RD, &ccpu, 0, ""); >>[...] >> >>Too fast. >> >># grep -r kern.ccpu /usr/src/ > > > We should retain the old location as well under COMPAT_FREEBSD[456]. It > doesn't cost anything and we should treat the sysctl tree like any other > API to the extent possible. > > -- Brooks > > Well, sysctl's are a second class API. The ease by they can be changed, as well as the completely uncontrolled nature that they are developed in, means that we really start to hamstring ourselves if we declare them as a first class API. What we should do instead is define a subset of the sysctl tree that is stable and guaranteed to exist, and declare that the rest are transient and therefore not part of the API. Doing this by popular vote is impractical, what we need is someone to sit down and audit what is there now and make appropriate recommendations. sysctls that are used by libkvm are a good candidate, for example, but random driver sysctls might not be. Scott