From owner-freebsd-bugs Thu Apr 20 4:40: 5 2000 Delivered-To: freebsd-bugs@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (Postfix) with ESMTP id 6E8D337BDE6 for ; Thu, 20 Apr 2000 04:40:03 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.9.3/8.9.2) id EAA42860; Thu, 20 Apr 2000 04:40:02 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Date: Thu, 20 Apr 2000 04:40:02 -0700 (PDT) Message-Id: <200004201140.EAA42860@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Alexander Langer Subject: Re: misc/18109: if pw_shell is empty(/bin/sh is assumed), cannot login via ssh. Reply-To: Alexander Langer Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org The following reply was made to PR misc/18109; it has been noted by GNATS. From: Alexander Langer To: noroi@mob.or.jp Cc: freebsd-gnats-submit@FreeBSD.ORG Subject: Re: misc/18109: if pw_shell is empty(/bin/sh is assumed), cannot login via ssh. Date: Thu, 20 Apr 2000 13:31:07 +0200 Thus spake noroi@mob.or.jp (noroi@mob.or.jp): > + if (pw->pw_shell[0] != '\0') { > /* deny if shell does not exists or is not executable */ > if (stat(pw->pw_shell, &st) != 0) > return 0; > if (!((st.st_mode & S_IFREG) && (st.st_mode & (S_IXOTH|S_IXUSR|S_IXGRP)))) > return 0; > + } You should add indentation to make your code more readable. What will happen if it is == 0 now? Alex -- I need a new ~/.sig. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message