From owner-cvs-sys Thu Oct 3 00:08:52 1996 Return-Path: owner-cvs-sys Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id AAA07283 for cvs-sys-outgoing; Thu, 3 Oct 1996 00:08:52 -0700 (PDT) Received: from time.cdrom.com (time.cdrom.com [204.216.27.226]) by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id AAA07275; Thu, 3 Oct 1996 00:08:50 -0700 (PDT) Received: from time.cdrom.com (localhost [127.0.0.1]) by time.cdrom.com (8.7.6/8.6.9) with ESMTP id AAA10557; Thu, 3 Oct 1996 00:08:34 -0700 (PDT) To: sos@FreeBSD.org cc: peter@spinner.DIALix.COM (Peter Wemm), jkh@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/i386/isa syscons.c In-reply-to: Your message of "Thu, 03 Oct 1996 08:57:42 +0200." <199610030657.IAA07715@ra.dkuug.dk> Date: Thu, 03 Oct 1996 00:08:34 -0700 Message-ID: <10555.844326514@time.cdrom.com> From: "Jordan K. Hubbard" Sender: owner-cvs-sys@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk > Excuse me, but I tend to think that the compiler should be fixed here... Fixed how? It's not broken. :-) We're compiling syscons.c with -Wunused and gcc, faithfully according to instruction, is warning you about unused variables. __unused sounds kinda gross, but it's still worlds better than the /* WUNUSED*/ comments which were "magically understood" by lint, along with /* NOTREACHED */. It's just not possible to make the verifier flag these cases in a "DWIM" fashion, since an intentional omission is indistinguishable from a bug at that level, so you either don't ask for -Wunused warnings or you give the compiler hints. Seems reasonable to me! Jordan