Date: Mon, 3 Dec 2012 11:56:16 +0100 From: Pietro Cerutti <gahr@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r308132 - head/audio/amrcoder Message-ID: <20121203105616.GA86596@gahrfit.gahr.ch> In-Reply-To: <20121203105040.GA30670@FreeBSD.org> References: <201212031034.qB3AYpkL004754@svn.freebsd.org> <20121203105040.GA30670@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--ew6BAiZeqk4r7MaW Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2012-Dec-03, 10:50, Alexey Dokuchaev wrote: > On Mon, Dec 03, 2012 at 10:34:51AM +0000, Pietro Cerutti wrote: > > New Revision: 308132 > > URL: http://svnweb.freebsd.org/changeset/ports/308132 > >=20 > > @@ -23,4 +18,7 @@ MANCOMPRESSED=3D yes > > post-extract: > > @${RM} ${WRKSRC}/*.o > > =20 > > +post-patch: > > + ${REINPLACE_CMD} -e 's|O4|O3|' ${WRKSRC}/${MAKEFILE} > > + >=20 > I recall this is not the first similar fix. Is there reason not to uphold > ${CFLAGS} here instead? CFLAGS as set by the user are used: cc -O2 -pipe -fno-strict-aliasing -O3 -I/src -DVAD1 -std=3Dgnu99 -Qunused-arguments -fstack-protector -c decoder.c I see no reason, however, not to let the author supersede them with more appropriate flags. --=20 Pietro Cerutti The FreeBSD Project gahr@FreeBSD.org PGP Public Key: http://gahr.ch/pgp --ew6BAiZeqk4r7MaW Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlC8hU8ACgkQwMJqmJVx945zuwCdE1QSgOSmTQd3MyeRQqVV9R4V KhYAnjLGGiV4q+u8tjt/B/xTaR8M6bd0 =hcHF -----END PGP SIGNATURE----- --ew6BAiZeqk4r7MaW--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121203105616.GA86596>