From owner-cvs-all@FreeBSD.ORG Tue Jul 5 18:25:22 2005 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 98D4916A41C for ; Tue, 5 Jul 2005 18:25:22 +0000 (GMT) (envelope-from maksim.yevmenkin@gmail.com) Received: from rproxy.gmail.com (rproxy.gmail.com [64.233.170.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 46F7243D4C for ; Tue, 5 Jul 2005 18:25:22 +0000 (GMT) (envelope-from maksim.yevmenkin@gmail.com) Received: by rproxy.gmail.com with SMTP id i8so922465rne for ; Tue, 05 Jul 2005 11:25:21 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=eK0K845Dno8UZf2sh/lw/nbOfJk+uVA11MuJPHwg0o9CseRy4J98/dhPJPO7KsESihh+m+5dAhvZFjrVJKUz3Cv61PdUKKmIzwg9RWJxWOZdmdeKe4f1CfWKK4qOZe2F6ZaZ7DKI7k4WgpgppYPnUDLO16HGMk3EjfWfLwXKs+g= Received: by 10.38.92.36 with SMTP id p36mr4178346rnb; Tue, 05 Jul 2005 11:25:21 -0700 (PDT) Received: by 10.38.208.5 with HTTP; Tue, 5 Jul 2005 11:25:21 -0700 (PDT) Message-ID: Date: Tue, 5 Jul 2005 11:25:21 -0700 From: Maksim Yevmenkin To: Gleb Smirnoff In-Reply-To: <20050705180335.GB5440@cell.sick.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <200507051735.j65HZK06019006@repoman.freebsd.org> <20050705180154.GA5440@cell.sick.ru> <20050705180335.GB5440@cell.sick.ru> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netgraph netgraph.h ng_base.c ng_socket.c ng_socketvar.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Maksim Yevmenkin List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jul 2005 18:25:22 -0000 Gleb, i took a brief look at the code, and, i think, everything should be fine. as stated in the commit message EINPROGRESS can only be returned if sender asked for it, i.e. passed the NG_PROGRESS flag to the ng_snd_item(). since none of the NG_SEND_MSG_HOOK(), NG_SEND_MSG_PATH(), NG_SEND_MSG_ID(), NG_FWD_MSG_HOOK() and NG_RESPOND_MSG() macros pass the NG_PROGRESS flag to the ng_snd_item() then this change should have no effect of the current code. sorry for the noise, i just wanted to make sure we do not have change existing code to check for EINPROGRESS error. thanks, max On 7/5/05, Gleb Smirnoff wrote: > On Tue, Jul 05, 2005 at 10:01:54PM +0400, Gleb Smirnoff wrote: > T> It can affect userland code. But only if there are some errors in code= . >=20 > I mean: it can affect userland programs, if there are erros in kernel sid= e. > In this commit, or in related code. If everything is correct, it won't > affect anything. >=20 > I run mpd for several weeks with this patch. >=20 > -- > Totus tuus, Glebius. > GLEBIUS-RIPN GLEB-RIPE >