Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 11 Jul 2013 04:50:01 GMT
From:      dfilter@FreeBSD.ORG (dfilter service)
To:        freebsd-fs@FreeBSD.org
Subject:   Re: kern/180236: commit references a PR
Message-ID:  <201307110450.r6B4o1kI018136@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/180236; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/180236: commit references a PR
Date: Thu, 11 Jul 2013 04:48:02 +0000 (UTC)

 Author: kib
 Date: Thu Jul 11 04:47:44 2013
 New Revision: 253183
 URL: http://svnweb.freebsd.org/changeset/base/253183
 
 Log:
   MFC r252714:
   The tvp vnode on rename is usually unlinked.  Drop the cached null
   vnode for tvp to allow the free of the lower vnode, if needed.
   
   PR:	kern/180236
 
 Modified:
   stable/9/sys/fs/nullfs/null_vnops.c
 Directory Properties:
   stable/9/sys/   (props changed)
   stable/9/sys/fs/   (props changed)
 
 Modified: stable/9/sys/fs/nullfs/null_vnops.c
 ==============================================================================
 --- stable/9/sys/fs/nullfs/null_vnops.c	Thu Jul 11 03:57:53 2013	(r253182)
 +++ stable/9/sys/fs/nullfs/null_vnops.c	Thu Jul 11 04:47:44 2013	(r253183)
 @@ -554,6 +554,7 @@ null_rename(struct vop_rename_args *ap)
  	struct vnode *fvp = ap->a_fvp;
  	struct vnode *fdvp = ap->a_fdvp;
  	struct vnode *tvp = ap->a_tvp;
 +	struct null_node *tnn;
  
  	/* Check for cross-device rename. */
  	if ((fvp->v_mount != tdvp->v_mount) ||
 @@ -568,7 +569,11 @@ null_rename(struct vop_rename_args *ap)
  		vrele(fvp);
  		return (EXDEV);
  	}
 -	
 +
 +	if (tvp != NULL) {
 +		tnn = VTONULL(tvp);
 +		tnn->null_flags |= NULLV_DROP;
 +	}
  	return (null_bypass((struct vop_generic_args *)ap));
  }
  
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201307110450.r6B4o1kI018136>