From owner-freebsd-hackers@FreeBSD.ORG  Sun Jan 11 02:37:00 2009
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E9520106564A
	for <freebsd-hackers@freebsd.org>; Sun, 11 Jan 2009 02:37:00 +0000 (UTC)
	(envelope-from pluknet@gmail.com)
Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.156])
	by mx1.freebsd.org (Postfix) with ESMTP id 53CCB8FC12
	for <freebsd-hackers@freebsd.org>; Sun, 11 Jan 2009 02:37:00 +0000 (UTC)
	(envelope-from pluknet@gmail.com)
Received: by fg-out-1718.google.com with SMTP id l26so3410004fgb.35
	for <multiple recipients>; Sat, 10 Jan 2009 18:36:59 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:received:received:message-id:date:from:to
	:subject:cc:in-reply-to:mime-version:content-type
	:content-transfer-encoding:content-disposition:references;
	bh=xGpG68czKsDPm38k7o+d5KLL6az4ShVGSZaEj2gx6bM=;
	b=pReTAi+wKCfs81rLYTzUWXjudhzqKhhYw3KNGOrM+iYjgnInU8LuMnHhZumUEJX1D9
	DJGRJxkw3REDiD7v76+NWnEaCX3aHo7KXECF86FaybPtAqqwUZxVcK9P1o6a5Aksb0vr
	p5Lb5EdJdzk5dBvzoIr3StfgckAcb4I2XSc5s=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=message-id:date:from:to:subject:cc:in-reply-to:mime-version
	:content-type:content-transfer-encoding:content-disposition
	:references;
	b=MnXFOK5kOSrGLd1Fmxwg5jLjJixRHgjjNlmhMWKWdja7QX+6JEcQFEls+hc8ho+2h5
	PNzvujSG9+phN9I3SeqoHqXj8SAh8/k1FCfZxq/j5Yv+5kwT+Ui4jW3kHHkdtXcAAEp5
	/5aj8sY6PIiUNbglapSKm1F5smok2iUNAO7AQ=
Received: by 10.86.79.4 with SMTP id c4mr1179183fgb.7.1231641419477;
	Sat, 10 Jan 2009 18:36:59 -0800 (PST)
Received: by 10.86.72.19 with HTTP; Sat, 10 Jan 2009 18:36:59 -0800 (PST)
Message-ID: <a31046fc0901101836q1f43028awe4f7b0ba746248ac@mail.gmail.com>
Date: Sun, 11 Jan 2009 05:36:59 +0300
From: pluknet <pluknet@gmail.com>
To: "Tim Kientzle" <kientzle@freebsd.org>
In-Reply-To: <49692659.2030306@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <49692659.2030306@freebsd.org>
Cc: freebsd-hackers@freebsd.org
Subject: Re: extattr problems?
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 11 Jan 2009 02:37:01 -0000

2009/1/11 Tim Kientzle <kientzle@freebsd.org>:
> FreeBSD 6.3:
>
> fd = open("test", O_WRONLY | O_CREAT | O_EXCL, 0777);
> n = extattr_set_fd(fd, EXTATTR_NAMESPACE_USER, "testattr", "1234", 4);
>
> After this, fd=3, n is non-zero, errno = 9 (EBADF)
>
> Huh?  I would have expected EOPNOTSUPP if
> extended attributes weren't supported on this
> filesystem.  The file descriptor is clearly
> valid.

Simple guess.
Don't hit me if I'm wrong. :)

You call open() with (O_CREAT | O_EXCL) on an already existing file.
If such then open() returns -1 with EEXIST and subsequent extattr_set_fd() call
with fd (-1) returns EBADF from getvnode() on failed
(td->td_proc->p_fd == NULL)
or
(fp = fdp->fd_ofiles[fd]) == NULL)
checks.

>
> Tim

-- 
wbr,
pluknet