From owner-cvs-src@FreeBSD.ORG Sat Jan 1 19:54:02 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3649E16A4CE; Sat, 1 Jan 2005 19:54:02 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 230CF43D2F; Sat, 1 Jan 2005 19:54:02 +0000 (GMT) (envelope-from kensmith@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j01Js1BW044549; Sat, 1 Jan 2005 19:54:02 GMT (envelope-from kensmith@repoman.freebsd.org) Received: (from kensmith@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j01Js1iY044548; Sat, 1 Jan 2005 19:54:01 GMT (envelope-from kensmith) Message-Id: <200501011954.j01Js1iY044548@repoman.freebsd.org> From: Ken Smith Date: Sat, 1 Jan 2005 19:54:00 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_4_11 Subject: cvs commit: src/sys/vm vm_map.c vm_object.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Jan 2005 19:54:02 -0000 kensmith 2005-01-01 19:54:00 UTC FreeBSD src repository Modified files: (Branch: RELENG_4_11) sys/vm vm_map.c vm_object.c Log: MFC of rev 1.329 of vm_object.c: date: 2004/07/28 18:23:08; author: alc; state: Exp; lines: +2 -2 Correct a very old error in both vm_object_madvise() (originating in vm/vm_object.c revision 1.88) and vm_object_sync() (originating in vm/vm_map.c revision 1.36): When descending a chain of backing objects, both use the wrong object's backing offset. Consequently, both may operate on the wrong pages. Quoting Matt, "This could be responsible for all of the sporatic madvise oddness that has been reported over the years." Reviewed by: Matt Dillon Reviewed by: alc Helped by: DFly vm_map.c rev 1.31, vm_object.c rev 1.17 Approved by: re (scottl) Revision Changes Path 1.187.2.31.2.1 +1 -1 src/sys/vm/vm_map.c 1.171.2.9.6.1 +2 -2 src/sys/vm/vm_object.c