From owner-cvs-src@FreeBSD.ORG  Wed Oct 29 06:51:30 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 1B5D216A4CE; Wed, 29 Oct 2003 06:51:30 -0800 (PST)
Received: from locore.org (ns01.locore.org [218.45.21.227])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 1E6AB43FBF; Wed, 29 Oct 2003 06:51:26 -0800 (PST)
	(envelope-from iwasaki@jp.FreeBSD.org)
Received: from localhost (ns01.locore.org [218.45.21.227])
	h9TEpORo020129;	Wed, 29 Oct 2003 23:51:24 +0900 (JST)
	(envelope-from iwasaki@jp.FreeBSD.org)
Date: Wed, 29 Oct 2003 23:51:21 +0900 (JST)
Message-Id: <20031029.235121.22011104.iwasaki@jp.FreeBSD.org>
To: truckman@FreeBSD.org
From: Mitsuru IWASAKI <iwasaki@jp.FreeBSD.org>
In-Reply-To: <200310290904.h9T94XeF028543@gw.catspoiler.org>
References: <200310290330.h9T3UjxH064205@repoman.freebsd.org>
	<200310290904.h9T94XeF028543@gw.catspoiler.org>
X-Mailer: Mew version 2.2 on Emacs 20.7 / Mule 4.0 (HANANOEN)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
cc: iwasaki@FreeBSD.org
Subject: Re: cvs commit: src/sys/conf options src/sys/i386/acpica Makefile
 acpi_wakecode.S src/sys/i386/conf NOTES
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Oct 2003 14:51:30 -0000

> On 28 Oct, Mitsuru IWASAKI wrote:
> > iwasaki     2003/10/28 19:30:45 PST
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     sys/conf             options 
> >     sys/i386/acpica      Makefile acpi_wakecode.S 
> >     sys/i386/conf        NOTES 
> >   Log:
> >   Add kernel option ACPI_NO_RESET_VIDEO as workaround for problems
> >   (e.g. LCD white-out after resume) on some machine cased by
> >   re-initialize video BIOS code in acpi_wakecode.
> >   
> >   Revision  Changes    Path
> >   1.420     +1 -0      src/sys/conf/options
> >   1.4       +4 -0      src/sys/i386/acpica/Makefile
> >   1.5       +2 -0      src/sys/i386/acpica/acpi_wakecode.S
> >   1.1097    +1 -0      src/sys/i386/conf/NOTES
> 
> I think this would be better as a tuneable instead of a compile time
> option.

Actually I thought so firstly, but concluded that kernel option is
better in this case. Two reasons:
1. Re-initialize video BIOS code is written in asm.  I want to keep it
   to be small as possible.
2. People won't try to enable or disable the code so many times.
   They will specify the option only once if necessary.

Thanks