From owner-freebsd-ports@freebsd.org Sun Nov 25 20:41:53 2018 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 32E701141C9A for ; Sun, 25 Nov 2018 20:41:53 +0000 (UTC) (envelope-from yuripv@yuripv.net) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2E88E7676D for ; Sun, 25 Nov 2018 20:41:51 +0000 (UTC) (envelope-from yuripv@yuripv.net) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 360C6285F0; Sun, 25 Nov 2018 15:41:45 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sun, 25 Nov 2018 15:41:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yuripv.net; h= subject:to:references:from:message-id:date:mime-version :in-reply-to:content-type; s=fm3; bh=Nk0b5nncsKgoYhk9LRRffRgcc1l AbjbRjMADpX2IOls=; b=vmsGNKbEkJyOIii3J7LptRXg5YHfTg6zMihE3WuK6ZY AoUQXJKREfvbezEC1Whz2zU/edWZG53A/RWzbPbm91e1CZhhBLQ4CwZEHEg+cJYG n11FddV+C1lhKmTgHkowvvw+66ikgc0ieRtI0FskyTN3VRhg0lpAUKtYIYtpbBZE I++V3nnMVsn3a8ygM3YY93kIFTyEGKMqai1tzkvb98qTXqxI1Auhuuq/8QSFk9+I XBCi8/blK72seQ7wq64HXNg4hrSAyZpK9m/Un5BVqHeR4Kn0jO90GiOI9qJ+zpUS ObgjALVovbuR9zcarC7p8a4pdhGOxEw5MTTWTPDOZhg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Nk0b5n ncsKgoYhk9LRRffRgcc1lAbjbRjMADpX2IOls=; b=i4o0AFrbz2QEVvgRHj1BEK Fb40yuUuCBpFkxFE+WxeCbVxljXr+v4LhTodZaGrYeLRm4lQ0whG0SdSwgeRSM9h XPwrxn6SkPvvnaw6PVdcirOSUdmAabthmLP6yMmERHPqZQnQQBDSJMPceqiU1ye5 n3Xh5mTViwUD6fXFyQTdIs5Tfe+13xi5TeiBgE0mw7tBwwkZHMD7/cwFifWIYIz2 wmT/WVBKEsRSuE6EhulfIcq5pEjmE4JN3akfsWAx2sv/JJyf6JJt0TYGczY+oj0d +OaHHphPeFozGCYwerpKcdtseAUpPR7rJdLQ6tH1/+Y2yOmEPsVwOulmIkZl9kdw == X-ME-Sender: X-ME-Proxy: Received: from thor.yuripv.net (unknown [62.183.125.179]) by mail.messagingengine.com (Postfix) with ESMTPA id D4F85102A0; Sun, 25 Nov 2018 15:41:43 -0500 (EST) Subject: Re: Best way to generate a patch file To: "Dan Mahoney (Gushi)" , freebsd-ports@freebsd.org References: From: Yuri Pankov Openpgp: preference=signencrypt Autocrypt: addr=yuripv@yuripv.net; keydata= xsBNBFu8u6IBCADB11gP0QwnorrHjqAtKLHKHNHskhy0s7jqJKfx0YqXgVBKGLJ9/mjLAz0F CBNvemHSDDTs0mEZ9cBKKi6cmsav6+UQgr//yai6hvXLBJqKchSFO4MhmdvBtsGFq1yKz5Zi uhjmimKyIpgBgvMdbgGbGq6cnSB2uEPmZuJr419SVRODOkXukU+F5WHgaHzDdHAIu1asCt2B +6msxqIqlFWcXyZyTGicTGGvC/PFIsVRUtD1dIJANTC876g7DTb7LZXWiWwJpSJ4GKMXMHVX Ct9BoQ4i3nhKbOxb6Io1wsy+NFyWsTJ9KYrxKKPJP3oG8BWb/cqlFqnE4eNSsiq2q7krABEB AAHNH1l1cmkgUGFua292IDx5dXJpcHZAeXVyaXB2Lm5ldD7CwJcEEwEIAEECGwMFCQWjmoAF CwkIBwMFFQoJCAsFFgMCAQACHgECF4AWIQT4arc+w94tPi0v/3CTi+B/sSrhbAUCW708wAIZ AQAKCRCTi+B/sSrhbPxBB/961alcU091O+yKT5/oReHVc/PX0Tz4sW3V44AcgLfYlrZavCro EFz90qmCrl0xqEwuAKcC4bjmL8SjPWAhSN6IH9nxdw+HeZnAPiHm/q679Bu47+nHBl3qD/9p +t1PkKeKZfaWToFMt1nq06ytSu6VLMCwLdlDNe6DReX0ex/afEqKsuaIZSKL4UYjRwklp8PU Uf98QkrfapyHB67hQMzfI4tPeJaYyv0cTgfq3kUWJx1V6Xi0b6Zxj4ZrB2TXvaMO5g7yhU9E E3WWAvoe4FgB3a7dHe8atnHhq5+Cuvm6+LD4Jh7jvMAE5UMN+xxQpnGpNghHjaCy4vXrLRBZ nhRYzsBNBFu8u6IBCADKih3Q933rDNj4ZA8FhBQ2RlmBgvwOLcDPIL3h0V7h38y3+HisgFSc XACDsdrTlYZ1bRXkD9FHENynBcv0l/3uGJDk8jaGIDE0TP8OQBRp+IaU9/BHnAqrKxTJGIol Dahy2m+yx2yhdc6B4ujWMDqCF1rWOD+ymOWw+VLllOkrHcZa5PJtX9UOGbApZl8ZTM8El4CA NN8F1bg9MWzUi+8LYoGWGc+BwsFS1OUB1c4SPgMu5fD4Wfsr9yRl06fdpEA2YT7B/j5/5RSC 0sE2Zs/tmJ/JRflHJ12ycj59ma2xQMfEJF40hZDpMFQmZvbVqgEg3ocQcltjbxlIKZ/mjC4z ABEBAAHCwHwEGAEKACYWIQT4arc+w94tPi0v/3CTi+B/sSrhbAUCW7y7ogIbDAUJBaOagAAK CRCTi+B/sSrhbIDcCACqAZMcoxUBLZa40a5b24j5i1jplvCYYb3h+Q5lt5+BFJ87kCb4dJuU D3kh2i29BrxWQWa9WNue9ozxeYkbkfXubQYXexVolRsnh64OdGsE8KvorBFBB3zdK/GRt2Jy +jsnTfUWuQllbzMP0MfhCDMk1Mo8WvDH2/cOEP/yLKf20a+cd6nLs7bidjmGXo9pyuBKAtV6 Kv+VRu54AL+A/UBYu/eB3Dtvzcnut+1Zq6KaP++kUwPwINLIk04OBDwN0zRNTiqMAFYYyz2v ZHBB6E1th/l//ZC5b9Dk0ZpFI1bYdL9ymnrZe1MqbGPnDCToQxu00T/pZCm6Z92YrZQYuNwl Message-ID: Date: Sun, 25 Nov 2018 23:41:30 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="564dRwE3Va1w3dvo71Y0na5G42Hxnm8tl" X-Rspamd-Queue-Id: 2E88E7676D X-Spamd-Result: default: False [-5.53 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(0.00)[+ip4:66.111.4.28]; HAS_ATTACHMENT(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; DKIM_TRACE(0.00)[yuripv.net:+,messagingengine.com:+]; RCPT_COUNT_TWO(0.00)[2]; MX_GOOD(-0.01)[in2-smtp.messagingengine.com,in1-smtp.messagingengine.com,in2-smtp.messagingengine.com,in1-smtp.messagingengine.com,in2-smtp.messagingengine.com,in1-smtp.messagingengine.com,in2-smtp.messagingengine.com,in1-smtp.messagingengine.com,in2-smtp.messagingengine.com,in1-smtp.messagingengine.com]; SIGNED_PGP(-2.00)[]; NEURAL_HAM_SHORT(-0.82)[-0.824,0]; RCVD_IN_DNSWL_LOW(-0.10)[28.4.111.66.list.dnswl.org : 127.0.5.1]; RECEIVED_SPAMHAUS_PBL(0.00)[179.125.183.62.zen.spamhaus.org : 127.0.0.11]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:11403, ipnet:66.111.4.0/24, country:US]; MID_RHS_MATCH_FROM(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; ARC_NA(0.00)[]; RECEIVED_SPAMHAUS_XBL(3.00)[179.125.183.62.zen.spamhaus.org : 127.0.0.4]; R_DKIM_ALLOW(0.00)[yuripv.net,messagingengine.com]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.20)[multipart/signed,multipart/mixed,text/plain]; DMARC_NA(0.00)[yuripv.net]; BAD_REP_POLICIES(0.10)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; IP_SCORE(-3.50)[ip: (-9.11), ipnet: 66.111.4.0/24(-4.39), asn: 11403(-3.88), country: US(-0.09)] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Nov 2018 20:41:53 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --564dRwE3Va1w3dvo71Y0na5G42Hxnm8tl Content-Type: multipart/mixed; boundary="fWk0cgJyBsypZ9Ndm7LKIrmPTgna87onD"; protected-headers="v1" From: Yuri Pankov To: "Dan Mahoney (Gushi)" , freebsd-ports@freebsd.org Message-ID: Subject: Re: Best way to generate a patch file References: In-Reply-To: --fWk0cgJyBsypZ9Ndm7LKIrmPTgna87onD Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Dan Mahoney (Gushi) wrote: > All, >=20 > I'm requesting takeover of a couple of FreeBSD ports (cvs and dma, > although dma is now in base, I imagine the port will be used to track > upstream changes before they make it into base). >=20 > What has been requested thusfar is a diff to update maintainer.=C2=A0 S= eems > simple enough, right, effectively a one-line patch/diff? >=20 > So, how do I go about it?=C2=A0 I could certainly cd to /usr/ports/mail= /dma, > copy Makefile to Makefile.orig, and run a manual diff Makefile.orig > Makefile > /tmp/patch, while in that directory.=C2=A0 That would apply = only > for the single file, obviously. >=20 > Or I could clone the entire port, and make a unified diff.=C2=A0 Yes, m= ore > complicated and perhaps unnecessary for a one-line-in-one-file patch, > but maybe some tooling expects that (I couldn't find a good rule of > thumb here). >=20 > Finally, in googling around, I found a makefile target that's called > "make makepatch" -- which isn't documented in 'man ports', and which I > *think* is not used for tracking patches that will live the lifetime of= > a port, but there's no section in the porters handbook that covers this= =2E >=20 > That is to say, the entire "patching" section in the porter's handbook > covers "lifecycle" (./files) patches, and not "bugreport" patches: >=20 > https://www.freebsd.org/doc/en/books/porters-handbook/slow-patch.html Check https://www.freebsd.org/doc/en/books/porters-handbook/port-upgrading.html= #svn-diff. Also, I think it's general rule of thumb that you should set yourself as maintainer along with submitting actual changes to the port (upgrading, fixing, etc.). --fWk0cgJyBsypZ9Ndm7LKIrmPTgna87onD-- --564dRwE3Va1w3dvo71Y0na5G42Hxnm8tl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEE+Gq3PsPeLT4tL/9wk4vgf7Eq4WwFAlv7CQUACgkQk4vgf7Eq 4Wx91ggAgH5bcblLoIncONiJgHlOVM9KexLRMfpNeQhewWiKgvQhxXbS+b+OAqz2 92tEI+9IRETO5XW+ZBUnjSAPYr2LMvLQAY3E1IA6TFcJHQiwfN8I8vD0YEShZf5T FhkAJNjNNxONv6fJtczfVW1ZXh0KQgsM82GeWBTCObZIXS0koHN5z+F77TlGxPSw d5i2TzifcTcdTDqY/NG/SfRkQn5w5h1p0ht31J4MedlPno7ZNe9GWCe2fPXf7jaE t/eWP16PecCUt5L5sOvnBxN3NwSgexAxYWuFqu/H26TO1pHOKWR3Z9BMG5oABHz9 kCkZG0jnwvrZCYvEZuuk8O2H5Es2Pg== =CMBt -----END PGP SIGNATURE----- --564dRwE3Va1w3dvo71Y0na5G42Hxnm8tl--