From owner-freebsd-current@FreeBSD.ORG Sat Feb 1 00:36:41 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3AAD3278; Sat, 1 Feb 2014 00:36:41 +0000 (UTC) Received: from mail-la0-x229.google.com (mail-la0-x229.google.com [IPv6:2a00:1450:4010:c03::229]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 7753D1938; Sat, 1 Feb 2014 00:36:40 +0000 (UTC) Received: by mail-la0-f41.google.com with SMTP id mc6so4012685lab.14 for ; Fri, 31 Jan 2014 16:36:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=z95fCnFXWbBWu7Zfvj2rISt9qc7r+AelXpFeELGSA0c=; b=rHSssnDXz/pBB751kABs6fRKT9mKQoYMUK4EMgDVByBTTB2JuwVWON/JGGWyg+mHLt XoBEEJ+UwG2Gk8gCkTWTk8KEw3aKYhOEyx5xXV6/FuerHEth4qWWQWHvNF/ytaDDwBak 76L1Y/192b4coiKo4chHI9sWj/iXKzviQJ761WiaddINt2kMicoOXM5Sr3Uz1P27/9ig MGV+3gdGM5+soykv9rWRDtVWrCD+7Rd9+jVn9/o7EvVJHx7pA4L+6ZYNu2zqXPm3nNjU HHJb7EKm8CXWLs3WJ7v80w2fDq22Bqk8vFxz7RhE0jF1w/KS7wjGgave2g0Awnu8YJh8 V4LQ== MIME-Version: 1.0 X-Received: by 10.152.8.47 with SMTP id o15mr3802570laa.20.1391214998420; Fri, 31 Jan 2014 16:36:38 -0800 (PST) Received: by 10.112.89.168 with HTTP; Fri, 31 Jan 2014 16:36:38 -0800 (PST) In-Reply-To: <52EC3B6C.20202@freebsd.org> References: <52E8DDA3.3070301@bitfrost.no> <52E9F546.9090005@bitfrost.no> <52EB4DBE.20501@bitfrost.no> <52EC07CE.70608@freebsd.org> <52EC2889.9020107@bitfrost.no> <38C22813-14E0-45A2-80CC-ED17525F6B95@gmail.com> <52EC3B6C.20202@freebsd.org> Date: Sat, 1 Feb 2014 08:36:38 +0800 Message-ID: Subject: Re: Apple Trackpad driver From: Huang Wen Hui To: "Danilo E. Gondolfo" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.17 Cc: freebsd-current X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list Reply-To: huanghwh@gmail.com List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Feb 2014 00:36:41 -0000 Hi, I tried to add to support modem macbooks into atp(4) at the beginning, but realized that atp(4) is very different from new touchpad hardware, so I give up, I think some one can do that. Cheers, Huang Wen Hui 2014-02-01 Danilo E. Gondolfo : > On 01/31/14 21:45, =E9=BB=84=E6=96=87=E8=BE=89@Gmail wrote: > > Hi Hans, > > Yes, I wrote wsp base on atp(4) and bcm5974.c from Linux. Of course we > can add a notice about that. Table and some structure bt_data, tp_finger > from Linux, I only wrote wsp_intr_callback base on usbdump, all other par= t > should be belong to Hans. > > > > Cheers, > > > > Huang Wen Hui > > > >> =E5=9C=A8 2014=E5=B9=B42=E6=9C=881=E6=97=A5=EF=BC=8C6:49=EF=BC=8CHans = Petter Selasky =E5=86=99=E9=81=93=EF=BC=9A > >> > >>> On 01/31/14 21:30, Danilo E. Gondolfo wrote: > >>>> On 01/31/14 05:16, Hans Petter Selasky wrote: > >>>>> On 01/31/14 02:46, Huang Wen Hui wrote: > >>>>> Hi Hans, > >>>>> > >>>>> pos_x[] is not non-inialized, it may be previous pos_x, it is stil= l > >>>>> ok for > >>>>> getting dx. > >>>>> "n" var is trying to reduce "untouch" sensor data for post > >>>>> proccessing. I > >>>>> attach a new patch > >>>>> may be more clear, also fixed unexpected movement when button statu= s > or > >>>>> ntouch changing. > >>>>> > >>>>> Cheers, > >>>>> > >>>>> Huang Wen Hui > >>>> Hi, > >>>> > >>>> http://svnweb.freebsd.org/changeset/base/261315 > >>>> > >>>> --HPS > >>> Good work! > >>> > >>> I noticed that your driver is based on the Linux driver [1] and some > >>> pieces of code are copied, are you sure that we won't have any proble= ms > >>> with license? > >>> > >>> These changes can be (should be) merged in the driver atp(4), no? > >>> > >>> Danilo. > >>> > >>> > >>> [1] - > http://lxr.free-electrons.com/source/drivers/input/mouse/bcm5974.c > >> Hi, > >> > >> It looks to me like some tables have been copied. We probably should > add a notice about that. The rest of the code looks OK to me. > >> > >> Huang, any comments? > >> > >> --HPS > >> > > > > Hello, > > And what about keeping these two driver? (atp and wsp) > Both has the same purpose. Wouldn't be better merge the new code on atp? > > On freebsd-drivers@ the author of the atp driver started a thread about > this [1]. > > Danilo. > > [1] - > http://lists.freebsd.org/pipermail/freebsd-drivers/2014-January/001659.ht= ml > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org= " >