Date: Sun, 19 May 2002 10:29:57 -0400 (EDT) From: Robert Watson <rwatson@FreeBSD.org> To: current@FreeBSD.org Subject: Bug in -current flock()? Message-ID: <Pine.NEB.3.96L.1020519102843.72574Q-100000@fledge.watson.org>
next in thread | raw e-mail | index | archive | help
I don't know much (anything) about the advisory locking code, but was
puzzled to see the following at the bottom of the flock() system call code
in kern_descrip.c:
if (uap->how & LOCK_EX)
lf.l_type = F_WRLCK;
else if (uap->how & LOCK_SH)
lf.l_type = F_RDLCK;
else {
error = EBADF;
goto done2;
}
FILE_LOCK(fp);
fp->f_flag |= FHASLOCK;
FILE_UNLOCK(fp);
error = VOP_ADVLOCK(vp, (caddr_t)fp, F_SETLK, &lf,
(uap->how & LOCK_NB) ? F_FLOCK : F_FLOCK | F_WAIT);
done2:
fdrop(fp, td);
mtx_unlock(&Giant);
return (error);
}
My reading of that is that the fp->f_flag field will be unconditionally
updated to include FHASLOCK, even if VOP_ADVLOCK() returns an error. Is
this correct?
Robert N M Watson FreeBSD Core Team, TrustedBSD Project
robert@fledge.watson.org NAI Labs, Safeport Network Services
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1020519102843.72574Q-100000>