From owner-cvs-ports@FreeBSD.ORG  Mon Jul 30 04:21:33 2007
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A040F16A41A;
	Mon, 30 Jul 2007 04:21:33 +0000 (UTC)
	(envelope-from kris@obsecurity.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.freebsd.org (Postfix) with ESMTP id 5DA9D13C442;
	Mon, 30 Jul 2007 04:21:33 +0000 (UTC)
	(envelope-from kris@obsecurity.org)
Received: from rot26.obsecurity.org (elvis.mu.org [192.203.228.196])
	by elvis.mu.org (Postfix) with ESMTP id 2EA151A4D7C;
	Sun, 29 Jul 2007 21:21:17 -0700 (PDT)
Received: by rot26.obsecurity.org (Postfix, from userid 1001)
	id A8E03BA4A; Mon, 30 Jul 2007 00:21:32 -0400 (EDT)
Date: Mon, 30 Jul 2007 00:21:32 -0400
From: Kris Kennaway <kris@obsecurity.org>
To: Dirk Meyer <dirk.meyer@dinoex.sub.org>
Message-ID: <20070730042132.GA95190@rot26.obsecurity.org>
References: <z1/R6s1x4l@dmeyer.dinoex.sub.org>
	<200706261648.l5QGmc0v079236@repoman.freebsd.org>
	<200706261648.l5QGmc0v079236@repoman.freebsd.org>
	<20070729183544.GC90318@rot26.obsecurity.org>
	<z1/R6s1x4l@dmeyer.dinoex.sub.org>
	<20070729211137.GA90226@rot26.obsecurity.org>
	<k9RLS81x4l@dmeyer.dinoex.sub.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <k9RLS81x4l@dmeyer.dinoex.sub.org>
User-Agent: Mutt/1.4.2.3i
Cc: cvs-ports@FreeBSD.org, ports-committers@FreeBSD.org, cvs-all@FreeBSD.org,
	kris@obsecurity.org
Subject: Re: cvs commit: ports/mail/meta1 Makefile
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Jul 2007 04:21:33 -0000

On Mon, Jul 30, 2007 at 05:46:22AM +0200, Dirk Meyer wrote:
> 
> > > > > | +MANUAL_PACKAGE_BUILD=	needs hostname
> > > > 
> > > > Why does the package need a hostname?  Often this is a bug, and either
> > > > way the preferred solution is to fix it so it can be packaged.
> > > 
> > > Ports failed in configure state,
> > > as the empty hostname breaks some sanity checks.
> > 
> > Yes, but why does the configure script need a hostname?  In most cases
> > it shouldn't be requiring one.
> 
> This ist not most cases.
> Some programs need to find out how the "hostname" command works.
> If they get an empty result, this will fail.
> 
> So rather them having pointyhat build bad packages,
> I decided that users are better off without them.

Sounds trivial to patch the configure script to skip the check since
we know exactly how FreeBSD's hostname command works.

Kris