From owner-cvs-all@FreeBSD.ORG Tue Oct 24 18:47:38 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B14A216A403; Tue, 24 Oct 2006 18:47:38 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 98FBD43D90; Tue, 24 Oct 2006 18:47:06 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id k9OIktLv011325; Tue, 24 Oct 2006 14:47:03 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: David Xu Date: Tue, 24 Oct 2006 14:30:11 -0400 User-Agent: KMail/1.9.1 References: <200610212359.k9LNxF2P014387@repoman.freebsd.org> <200610231133.29990.jhb@freebsd.org> <200610240647.03765.davidxu@freebsd.org> In-Reply-To: <200610240647.03765.davidxu@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200610241430.12149.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Tue, 24 Oct 2006 14:47:03 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/2091/Tue Oct 24 09:27:53 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_exit.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Oct 2006 18:47:38 -0000 On Monday 23 October 2006 18:47, David Xu wrote: > On Monday 23 October 2006 23:33, John Baldwin wrote: > > On Saturday 21 October 2006 19:59, David Xu wrote: > > > davidxu 2006-10-21 23:59:15 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > sys/kern kern_exit.c > > > Log: > > > Since revision 1.333 of kern_sig.c no longer uses P_WEXIT, the change > > > opened a race window which can cause memory leak in signal queue. > > > Here we free memory for signal queue when process state is set to > > > PRS_ZOMBIE. > > > > Is there any reason to not just harvest it in wait() instead? > > I prefer to free it earlier rather than delaying it if I can. But we already do the free'ing "later" (wait() really isnt' all that later than exit1() for most processes) for sigacts, limits, etc. It would seem that sigqueue and sigacts would have nearly identical lifetimes. -- John Baldwin