From owner-freebsd-geom@FreeBSD.ORG  Tue Apr  5 14:05:53 2005
Return-Path: <owner-freebsd-geom@FreeBSD.ORG>
Delivered-To: freebsd-geom@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 4C78516A4E1; Tue,  5 Apr 2005 14:05:53 +0000 (GMT)
Received: from critter.freebsd.dk (f170.freebsd.dk [212.242.86.170])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 60D1843D2F; Tue,  5 Apr 2005 14:05:52 +0000 (GMT)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.13.3/8.13.1) with ESMTP id j35E4owx012350;
	Tue, 5 Apr 2005 16:05:50 +0200 (CEST)
	(envelope-from phk@critter.freebsd.dk)
To: "Wojciech A. Koszek" <dunstan@freebsd.czest.pl>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Tue, 05 Apr 2005 14:07:35 -0000."
             <20050405140735.GA75518@freebsd.czest.pl> 
Date: Tue, 05 Apr 2005 16:04:50 +0200
Message-ID: <12349.1112709890@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
cc: Pawel Jakub Dawidek <pjd@freebsd.org>
cc: freebsd-geom@freebsd.org
Subject: Re: Panic while loading GEOM BSD class (KASSERTions) 
X-BeenThere: freebsd-geom@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: GEOM-specific discussions and implementations
	<freebsd-geom.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-geom>
List-Post: <mailto:freebsd-geom@freebsd.org>
List-Help: <mailto:freebsd-geom-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Apr 2005 14:05:53 -0000

In message <20050405140735.GA75518@freebsd.czest.pl>, "Wojciech A. Koszek" writ
es:
>On Tue, Apr 05, 2005 at 03:32:17PM +0200, Pawel Jakub Dawidek wrote:
>> On Mon, Apr 04, 2005 at 07:58:20PM +0000, Wojciech A. Koszek wrote:
>> +> Hello GEOM hackers,
>[..]
>> 
>> GEOM_BSD is always added to the kernel:
>> 
>> /sys/conf/files.alpha:geom/geom_bsd.c                   standard
>[..]
>> And if you want to ask if we should panic or not if class is already
>> there... I suggested phk@ in the past to just return an error, not
>> sure what his response was (maybe 'prepare a patch' :)).
>
>Hi Pawel,
>I mean exacly this. We have GEOM_BSD by default. but it would be nice to
>cleanly return with error code. Similar problem is reported with if_run.ko
>and if_ppp.ko (PR: kern/79493).

In current we have changed it to return EEXISTS if you try to load
a class with the same name as an already existing class.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.