Date: Tue, 31 Aug 1999 23:21:54 -0400 (EDT) From: Luoqi Chen <luoqi@watermarkgroup.com> To: current@FreeBSD.ORG, jeremyp@gsmx07.alcatel.com.au Cc: wpaul@FreeBSD.ORG Subject: Re: Problems with the latest changes to ifconfig (I guess) -> Bad guess... Message-ID: <199909010321.XAA28636@lor.watermarkgroup.com>
next in thread | raw e-mail | index | archive | help
> Ian Whalley <ian@whalley.org> wrote: > >My card is identified as <3Com 3c905B-TX Fast Etherlink XL>. > > FWIW, I'm running a kernel about 30 hours old with a <3Com 3c905-TX > Fast Etherlink XL> and I'm not seeing this problem. > > At a quick quess, something in the miibus support broke the 3C905B > support. > > Peter > I got the same panic tonight. The xlphy attach function doesn't clean up appropriately when it aborts, here's the fix. Index: exphy.c =================================================================== RCS file: /home/ncvs/src/sys/dev/mii/exphy.c,v retrieving revision 1.3 diff -u -r1.3 exphy.c --- exphy.c 1999/08/29 15:42:03 1.3 +++ exphy.c 1999/09/01 03:12:01 @@ -161,12 +161,6 @@ ma = device_get_ivars(dev); sc->mii_dev = device_get_parent(dev); mii = device_get_softc(sc->mii_dev); - LIST_INSERT_HEAD(&mii->mii_phys, sc, mii_list); - - sc->mii_inst = mii->mii_instance; - sc->mii_phy = ma->mii_phyno; - sc->mii_service = exphy_service; - sc->mii_pdata = mii; /* * The 3Com PHY can never be isolated, so never allow non-zero @@ -176,6 +170,12 @@ device_printf(dev, "ignoring this PHY, non-zero instance\n"); return(ENXIO); } + LIST_INSERT_HEAD(&mii->mii_phys, sc, mii_list); + + sc->mii_inst = mii->mii_instance; + sc->mii_phy = ma->mii_phyno; + sc->mii_service = exphy_service; + sc->mii_pdata = mii; mii->mii_instance++; -lq To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199909010321.XAA28636>