From owner-cvs-all Tue Jun 5 1:37:54 2001 Delivered-To: cvs-all@freebsd.org Received: from relay.nuxi.com (nuxi.cs.ucdavis.edu [169.237.7.38]) by hub.freebsd.org (Postfix) with ESMTP id 04F5737B405; Tue, 5 Jun 2001 01:37:49 -0700 (PDT) (envelope-from obrien@nuxi.ucdavis.edu) Received: from dragon.nuxi.com (root@trang.nuxi.com [206.40.252.115]) by relay.nuxi.com (8.11.2/8.11.2) with ESMTP id f558bml99163; Tue, 5 Jun 2001 01:37:48 -0700 (PDT) (envelope-from obrien@NUXI.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.11.3/8.11.1) id f558blE49395; Tue, 5 Jun 2001 01:37:47 -0700 (PDT) (envelope-from obrien) Date: Tue, 5 Jun 2001 01:37:47 -0700 From: "David O'Brien" To: dd@Freebsd.org, cvs-committers@Freebsd.org, cvs-all@Freebsd.org Subject: Re: cvs commit: src/sys/kern tty_snoop.c src/sys/sys snoop.h Message-ID: <20010605013747.A49295@dragon.nuxi.com> Reply-To: obrien@Freebsd.org References: <200106050500.f5550IM88505@freefall.freebsd.org> <3B1C7DE0.FDBD0D38@DougBarton.net> <20010605102149.C21191@sunbay.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010605102149.C21191@sunbay.com>; from ru@FreeBSD.org on Tue, Jun 05, 2001 at 10:21:49AM +0300 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, Jun 05, 2001 at 10:21:49AM +0300, Ruslan Ermilov wrote: > > > Log: > > > Style and cosmetic cleanups. This driver is now reasonably stlye(9) > > > compliant. All the variable definitions and function names are > > > reasonably consistent, and the functions which should be static (i.e., > > > all of them) are. Other assorted fixes were made. The majority of > > > the delta is indentation fixes. > > > > In my ever so humble opinion it's better to do the whitespace commits > > seperately. That makes it much easier to see the substantive changes. > > > cvs diff -w? Regardless, it is our practice to commit style/cosmetic changes by themselves with no functionality changes mixed in (and vice-versa). -- -- David (obrien@FreeBSD.org) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message