From owner-freebsd-current@FreeBSD.ORG Fri Dec 17 21:59:07 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2C9B5106566C; Fri, 17 Dec 2010 21:59:07 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 619448FC13; Fri, 17 Dec 2010 21:59:06 +0000 (UTC) Received: by wyf19 with SMTP id 19so1083948wyf.13 for ; Fri, 17 Dec 2010 13:59:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=l0R4zJFaOcxLWMWK9li0ro7/OkHfR0KRlItpSAybmFA=; b=d2POgPyMKDZ1w7BvILuTB6RsNxNFwag93Xw01w+20z5E+0ZbZWDpZqHBHh/crsccLL m7DXOJ41Kw3Mb/AT5dqr0mffQh+ZY+4o7b6INd1M+ZnUB2JEpcNrfvH+E4X0gS2i2Gof XTK1iY7kgC9y/N/BLACTKE0o0N0IoYd8gSFe4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=WK8rKzIkoK0D/y+q9S9S+YXtaNE6VOq9SLtm0533Kh+diPKujaq6HN0fXQn4IEtbh9 NE8DmtPN5QA9UIENJiPkw4tmHJC6Bq7zYVz+DObYrLYjB0qCPSNVpow9XvQXVNyCfME8 wd66n9hdJtpbgA5q63HUG+2Fa++8Tw+nnbX9Y= MIME-Version: 1.0 Received: by 10.216.71.209 with SMTP id r59mr4277957wed.15.1292623144415; Fri, 17 Dec 2010 13:59:04 -0800 (PST) Sender: yanegomi@gmail.com Received: by 10.216.198.27 with HTTP; Fri, 17 Dec 2010 13:59:04 -0800 (PST) In-Reply-To: References: <20101217143222.GA28086@freebsd.org> Date: Fri, 17 Dec 2010 13:59:04 -0800 X-Google-Sender-Auth: _ErZQB-lZw4OOV0lin17JrC6xfc Message-ID: From: Garrett Cooper To: bf1783@gmail.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Alexander Best , freebsd-current@freebsd.org, imp@freebsd.org Subject: Re: a few OptionalObsoleteFiles.inc improvements X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Dec 2010 21:59:07 -0000 On Fri, Dec 17, 2010 at 11:48 AM, b. f. wrote: > On 12/17/10, Alexander Best wrote: >> On Tue Dec 14 10, b. f. wrote: >>> Alexander Best wrote: > > ... > >>> The last part of your patch reverts a change that Warner Losh made in >>> r212525 as part of his tbemd project merge. =A0It's possible that this >>> change may have been an unintended, but it followed a discussion in >>> which Warner rejected a related patch proposed by Garrett Cooper, >>> partly because sysinstall is included in build-tools in Makefile.inc1, >>> even though some thought that it should not be. =A0In any event, you >>> should probably look into that before committing the last part of your >>> patch. >> >> so is csh, but still you can set WITHOUT_TCSH=3Dtrue and have a world wi= thout >> (t)csh. > > I'll be more explicit: > > Garrett's original patch went a little farther than yours: he also > conditionally removed sysinstall (subject to the use of > WITHOUT_SYSINSTALL) from build-tools in Makefile.inc1, as is done now > under other knobs with sys/modules/aic7xxx/aicasm, > share/syscons/scrnmaps, kerberos5/tools, and rescue/rescue. =A0That is > primarily what resulted in it being rejected, as no one remembered why > it had been added in: > > http://svn.freebsd.org/viewvc/base?view=3Drevision&revision=3D71238 > > Subsequently, Warner agreed that it could in fact be removed: > > http://lists.freebsd.org/pipermail/freebsd-arch/2010-June/010398.html > > However, he didn't remove it, and even later effectively disabled the > WITHOUT_SYSINSTALL knob. =A0So I'm suggesting that you find out why he > changed his mind (it may have been an oversight), and if sysinstall > really isn't needed, then not only make the changes that you > originally proposed, but also prevent it from being built in the first > place during build-tools, like Garrett did. =A0(The same should be done > for other parts of that target, too, like the csh bits.) > > ... > >> no need to worry i'll commit any changes, since i don't have commit righ= ts. >> ;) > > ...or before asking someone else to commit it. In the same token I also added needed knobs to remove pc-sysinstall that wasn't really popular at the time because it had just been introduced into the tree. I hadn't gone to great lengths to validate that everything was sane with either a standard build or release (it would be nice if release could be tuned to use either pc-sysinstall or sysinstall, but for right now it's tied to sysinstall). Thanks! -Garrett