From owner-cvs-all@FreeBSD.ORG  Sun Jun 20 21:36:20 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 20CAA16A4CE; Sun, 20 Jun 2004 21:36:20 +0000 (GMT)
Received: from darkness.comp.waw.pl (darkness.comp.waw.pl [195.117.238.236])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 8807643D41; Sun, 20 Jun 2004 21:36:17 +0000 (GMT)
	(envelope-from pjd@darkness.comp.waw.pl)
Received: by darkness.comp.waw.pl (Postfix, from userid 1009)
	id 81D4FACADB; Sun, 20 Jun 2004 23:36:15 +0200 (CEST)
Date: Sun, 20 Jun 2004 23:36:15 +0200
From: Pawel Jakub Dawidek <pjd@FreeBSD.org>
To: Ruslan Ermilov <ru@FreeBSD.org>
Message-ID: <20040620213615.GQ12007@darkness.comp.waw.pl>
References: <200406181638.i5IGch7K079518@repoman.freebsd.org>
	<20040618164732.GB16260@ip.net.ua>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="B2gdd0vZVCwxSorY"
Content-Disposition: inline
In-Reply-To: <20040618164732.GB16260@ip.net.ua>
User-Agent: Mutt/1.4.2i
X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc
X-OS: FreeBSD 5.2.1-RC2 i386
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/share/mk bsd.kmod.mk
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 20 Jun 2004 21:36:20 -0000


--B2gdd0vZVCwxSorY
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jun 18, 2004 at 07:47:33PM +0300, Ruslan Ermilov wrote:
+> On Fri, Jun 18, 2004 at 04:38:43PM +0000, Pawel Jakub Dawidek wrote:
+> > pjd         2004-06-18 16:38:43 UTC
+> >=20
+> >   FreeBSD src repository
+> >=20
+> >   Modified files:
+> >     share/mk             bsd.kmod.mk=20
+> >   Log:
+> >   Check if ${_dir}/kern exists as well, because if it doesn't exists
+> >   we will fail later and we can miss good kernel source tree directory.
+> >   I found this trying to compile kld module and it finds 'conf/kmod.mk'
+> >   in '../..', but it fails later, because there is no 'kern' directory,
+> >   but there is valid kernel source tree still in /usr/src/sys/.
+> >  =20
+> >   Revision  Changes    Path
+> >   1.89      +2 -2      src/share/mk/bsd.kmod.mk
+> >=20
+> It fixes just one out of dozen other possibilities of partial checkouts.

Yes, but there are two checks:

For (...)
If exists(${_dir}/conf/<something>)
	Ok.
EndIf
EndFor
If !exists(${_dir}/conf) || !exists(${_dir}/kern)
	Bad.
EndIf

So IMHO we should check two directories in both places or one directory
in both places, but not one here and two there.
Does it make sense to you?

--=20
Pawel Jakub Dawidek                       http://www.FreeBSD.org
pjd@FreeBSD.org                           http://garage.freebsd.pl
FreeBSD committer                         Am I Evil? Yes, I Am!

--B2gdd0vZVCwxSorY
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)

iD8DBQFA1gNPForvXbEpPzQRAvgjAJ9n77dQ7VipW6a0Sgb9A9FlxIUASACgtnI/
3YPQHTBLYGB02KLDVVNG+AU=
=FPzj
-----END PGP SIGNATURE-----

--B2gdd0vZVCwxSorY--