From owner-freebsd-net@freebsd.org  Sat Jan 16 21:15:22 2016
Return-Path: <owner-freebsd-net@freebsd.org>
Delivered-To: freebsd-net@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 37E09A848B4
 for <freebsd-net@mailman.ysv.freebsd.org>;
 Sat, 16 Jan 2016 21:15:22 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 292B61D38
 for <freebsd-net@FreeBSD.org>; Sat, 16 Jan 2016 21:15:22 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u0GLFL2j083559
 for <freebsd-net@FreeBSD.org>; Sat, 16 Jan 2016 21:15:22 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-net@FreeBSD.org
Subject: [Bug 203922] The kern.ipc.acceptqueue limit is too low
Date: Sat, 16 Jan 2016 21:15:06 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: 11.0-CURRENT
X-Bugzilla-Keywords: needs-qa, patch, performance
X-Bugzilla-Severity: Affects Some People
X-Bugzilla-Who: alfred@FreeBSD.org
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-net@FreeBSD.org
X-Bugzilla-Flags: mfc-stable9? mfc-stable10?
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-203922-2472-cSZI1aQuZz@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-203922-2472@https.bugs.freebsd.org/bugzilla/>
References: <bug-203922-2472@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 16 Jan 2016 21:15:22 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D203922

--- Comment #6 from Alfred Perlstein <alfred@FreeBSD.org> ---
The correct way would be to retain the field as-is but rename it to "_old".

Then add a field with the correct width.

Then when exporting the field make sure to continue to export the _old stru=
ct
but carefully assign it using code as follows:
xpcb->qlen =3D newval
xpcb->qlen_old =3D qlen->qlen > (uint32_t)MAX_ISHORT ? MAX_USHORT : qlen->q=
len

Then possibly mark the old field for deprecation, but still really shouldn't
deprecate if we intend to be forever backwards compatible.

To _really_ fix it, there really should be an accessor library written so t=
hat
no one has to even know the size of xpcb other than the library.

--=20
You are receiving this mail because:
You are the assignee for the bug.=