From owner-svn-src-head@FreeBSD.ORG Thu Jan 10 00:08:28 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 91EDE90 for ; Thu, 10 Jan 2013 00:08:28 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from mail-da0-f48.google.com (mail-da0-f48.google.com [209.85.210.48]) by mx1.freebsd.org (Postfix) with ESMTP id 6BB838EE for ; Thu, 10 Jan 2013 00:08:27 +0000 (UTC) Received: by mail-da0-f48.google.com with SMTP id k18so996236dae.21 for ; Wed, 09 Jan 2013 16:08:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:content-transfer-encoding:message-id:references :to:x-mailer:x-gm-message-state; bh=o95yIakKdnWzpjk2dGbW34ZrOANi03DW3QEuk4kiGuk=; b=K8eYzhf74mckjLG2plzANgRRv1s4MJDTpP2l8FYZ9ooQiL+TM+Jotnr2WNzKPYWlgw VPK9WIcLqZvI6RJE6wHh3h+09Um21cFRm/dHp8vFZaGwX79Rz+VbSAB5dV0hPr/0LNC3 R41dHAkLMlkU7mvTA4+bDGDq2i3wBd8/gCdkIXIo9lRKVKRwGOT9dcsT36jkXPX0d63J GGfyqK+N29rNHjCMmpmrIGkEZfpNNvjslvo6t5gr7szh6NqZiWXmIdxfpmP5Tk9PWktD 9MsfYGzOg4R6kKj2M3HxX+D1ccKGSX15mcNIHEMCrBsB6DlpC+i2XlSw353MUnjxZdP/ TO9w== X-Received: by 10.66.52.79 with SMTP id r15mr194387174pao.46.1357776507335; Wed, 09 Jan 2013 16:08:27 -0800 (PST) Received: from fusionlt2834a.int.fusionio.com ([209.117.142.2]) by mx.google.com with ESMTPS id o1sm127152paw.0.2013.01.09.16.08.24 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 09 Jan 2013 16:08:26 -0800 (PST) Sender: Warner Losh Subject: Re: svn commit: r244585 - in head: . sys/geom/label Mime-Version: 1.0 (Apple Message framework v1085) Content-Type: text/plain; charset=us-ascii From: Warner Losh In-Reply-To: <20130109234526.GL2561@kib.kiev.ua> Date: Wed, 9 Jan 2013 17:08:23 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201212221343.qBMDhCHa086834@svn.freebsd.org> <201301070927.07157.jhb@freebsd.org> <20130108193146.GA1815@a91-153-116-96.elisa-laajakaista.fi> <201301091417.37451.jhb@freebsd.org> <20130109234526.GL2561@kib.kiev.ua> To: Konstantin Belousov X-Mailer: Apple Mail (2.1085) X-Gm-Message-State: ALoCoQnCNAakWbIYz87nCaA2unqoDFrYt5FqU9di/QJ1AnZx3gNcvEJ3OQd6OwELyXexN5WyhVjh Cc: Jaakko Heinonen , src-committers@freebsd.org, pjd@freebsd.org, John Baldwin , svn-src-all@freebsd.org, svn-src-head@freebsd.org, imp@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jan 2013 00:08:28 -0000 On Jan 9, 2013, at 4:45 PM, Konstantin Belousov wrote: > On Wed, Jan 09, 2013 at 02:17:37PM -0500, John Baldwin wrote: >> On Tuesday, January 08, 2013 2:31:47 pm Jaakko Heinonen wrote: >>> On 2013-01-07, John Baldwin wrote: >>>> I think if it isn't hard to do so, we should aim to preserve labels = as they=20 >>>> are generally intended to be human readable as-is. Just preserving = spaces is=20 >>>> probably sufficient for this as they are probably the most commonly = used=20 >>>> character in labels affected by this change. >>>=20 >>> All right. I have prepared patches for review. >>>=20 >>> - Quote device names in devctl(4) device events. This allows events = to >>> work for device names containing spaces. >>> - Allow spaces again in device names. >>>=20 >>> Requested by: jhb >>> PR: kern/161912 >>=20 >> Thanks. I think your patches look fine as far as I can tell. >=20 > I do not object, but IMHO having names with the spaces in /dev is = weird > and possibly problematic. This was the reason of my initial request to > disable spaces, together with the fact that it changes the devctl(4) > protocol (there might be other /dev/devctl readers besides devd). I'm not sure that the protocol changes are quire right yet... Warner