From owner-freebsd-arm@freebsd.org Thu Mar 3 07:10:04 2016 Return-Path: Delivered-To: freebsd-arm@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1B71AAC2F14 for ; Thu, 3 Mar 2016 07:10:04 +0000 (UTC) (envelope-from russ.haley@gmail.com) Received: from mail-vk0-x235.google.com (mail-vk0-x235.google.com [IPv6:2607:f8b0:400c:c05::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C78B41C81 for ; Thu, 3 Mar 2016 07:10:03 +0000 (UTC) (envelope-from russ.haley@gmail.com) Received: by mail-vk0-x235.google.com with SMTP id e6so12734537vkh.2 for ; Wed, 02 Mar 2016 23:10:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=HdNpmWofFb31hkd6GCZOsekzmdCiR0LTXbv93sgZuw4=; b=MqYcGAs2w/TPrhwWgtRxC23Xg8IpAi59Gp6bvb8pV272xJNrEborcJW1hCXPOi5JQ3 p1iuUJuJw0jXjBzrJ4Ruh8/Co3ZstzPOUF161a/5pk3bPe2SfmTiCHKlh8lv1A1dyKGH 8X5ENtGoNa6EpRiRMqoj1xrTnSayCHIYn6nlS1LR/W2vK5k6q51ozCC0tsX7wCotnZnK nqrChlnuqvaEXn3VMIkNvpawXMrI12fmX2erQGvGw39pKj2c9ux2C0vpJeOPJOeMn/fi jffEwxDxaJUvEYUdT0A4Wtk5a9b3GePE3G3fpRExLIoJgh3qyrvcxgBo9LAyBS7Y0T0h 8gbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=HdNpmWofFb31hkd6GCZOsekzmdCiR0LTXbv93sgZuw4=; b=Hrl+6b7zHes7n0GfAyFOAAntAmpmN8FiS+7jVyNJ8BgVHtkTsBwCSlpXGSDmjEQw7i 3h8L7hKqwitt/cxVga6xOVOZo2cKiiGLALmfnZWwdg1sIgL41jJ4/2h0qIna2rD710ji aj8spj0qklI1zoI8czwOQamTKXvgusi2egz8kfwx8MbcFlakY7Q4wjbRrhwEm0ktSeQ3 YwmRERjHGTbT0IGZ0oJeF7DDbsWi8QJU47Vds5gnZhC14QATe+3yWvmc9Su09029by9F 1laMTrehY1F7/BqPNMqz2mpovzhGp/CbHjPGOGLHIwdk+rxA8swJoLdEqc41ZT4Hd4OJ m4Hw== X-Gm-Message-State: AD7BkJITb42sL+37QMMLlwPypHf4VbBzs48RU7qOkZ8xCv8E4UuBxM7uk+ua4OEOAVAODpmaLA3MkY7meYq3og== MIME-Version: 1.0 X-Received: by 10.31.141.75 with SMTP id p72mr764977vkd.13.1456989002814; Wed, 02 Mar 2016 23:10:02 -0800 (PST) Received: by 10.31.54.13 with HTTP; Wed, 2 Mar 2016 23:10:02 -0800 (PST) In-Reply-To: <1456154162.1294.51.camel@freebsd.org> References: <20140216111153.GA74858@olymp.kibab.com> <5C2CF572-360D-4CA0-81C7-18A5C455AED5@bsdimp.com> <20140224142642.GA32538@olymp.kibab.com> <53120EE8.1080600@bakulin.de> <5688F015.4090002@bakulin.de> <6942A46B-110B-4E1F-9DA1-F965009E8E92@FreeBSD.org> <38dd08fc2a5930d58b09e9bd3cb6d3e7@bakulin.de> <1456154162.1294.51.camel@freebsd.org> Date: Wed, 2 Mar 2016 23:10:02 -0800 Message-ID: Subject: Re: MMC/SDIO stack under CAM From: Russell Haley To: Ilya Bakulin Cc: "freebsd-arm@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Mar 2016 07:10:04 -0000 Hello Ilya, I have tried running patch D4761 against r296336 and ran into a make error. As follows: cd /usr/src svn patch /usr/patches/D4761.diff U etc/mtree/BSD.include.dist > applied hunk @@ -92,6 +92,8 @@ with fuzz 2 > applied hunk @@ -224,7 +226,7 @@ with offset 2 U include/Makefile U lib/libcam/Makefile U sbin/camcontrol/camcontrol.c U sys/Makefile A sys/arm/conf/BEAGLEBONE-CAM U sys/arm/ti/ti_sdhci.c U sys/cam/cam_ccb.h U sys/cam/cam_xpt.c U sys/cam/cam_xpt_internal.h A sys/cam/mmc A sys/cam/mmc/mmc.h A sys/cam/mmc/mmc_all.h A sys/cam/mmc/mmc_bus.h A sys/cam/mmc/mmc_da.c A sys/cam/mmc/mmc_sdio.h A sys/cam/mmc/mmc_sdio.c A sys/cam/mmc/mmc_xpt.c A sys/cam/mmc/mmcreg.h U sys/conf/files > applied hunk @@ -1554,10 +1557,10 @@ with offset 6 > applied hunk @@ -1960,6 +1963,7 @@ with offset 10 A sys/dev/mmcnull A sys/dev/mmcnull/Makefile A sys/dev/mmcnull/mmcnull.c U sys/dev/sdhci/sdhci.h U sys/dev/sdhci/sdhci.c A sys/modules/mmcnull A sys/modules/mmcnull/Makefile root@a5e5b565-d3ae-11e5-a511-0c54a518c15b:/usr/src # ls .arcconfig bin rescue .arclint cddl sbin .svn contrib secure COPYRIGHT crypto share LOCKS etc sys MAINTAINERS gnu targets Makefile include tests Makefile.inc1 kerberos5 tools ObsoleteFiles.inc lib usr.bin README libexec usr.sbin UPDATING release #make TARGET=arm TARGET_ARCH=armv6 KERNCONF=IMX6 -j20 buildkernel ... --- mmc_da.o --- /usr/src/sys/cam/mmc/mmc_da.c:855:20: error: format specifies type 'unsigned long' but the argument has type 'uint64_t' (aka 'unsigned long long') [-Werror,-Wformat] softc->csd.capacity, ^~~~~~~~~~~~~~~~~~~ /usr/src/sys/cam/cam_debug.h:97:10: note: expanded from macro 'CAM_DEBUG' printf printfargs; \ ^ --- modules-all --- --- all_subdir_accf_dns --- --- accf_dns.o --- --- mmc_da.o --- 1 error generated. *** [mmc_da.o] Error code 1 make[2]: stopped in /usr/obj/arm.armv6/usr/src/sys/IMX6 --- modules-all --- Thanks, Russ On Mon, Feb 22, 2016 at 7:16 AM, Ian Lepore wrote: > On Sun, 2016-02-21 at 23:28 -0800, Russell Haley wrote: >> On Mon, Feb 15, 2016 at 9:33 PM, Warner Losh wrote: >> > On Mon, Feb 15, 2016 at 7:22 AM, NGie Cooper > > > wrote: >> > >> > > >> > > > On Feb 15, 2016, at 02:13, Ilya Bakulin >> > > > wrote: >> > > > >> > > > On 2016-02-11 19:54, Stanislav Sedov wrote: >> > > > > > On Feb 11, 2016, at 10:47 AM, Ilya Bakulin > > > > > > > wrote: >> > > > > > I'll use an excellent opportunity to post a small status >> > > > > > update about >> > > my work :-) >> > > > > > * SDHC controller on Wandboard now works with the new >> > > > > > stack; >> > > > > > * SDIO block read now works! >> > > > > > * camcontrol userland app is extended to support "mmcsdcmd" >> > > > > > command >> > > that allows to send MMC commands from userland apps directly to >> > > the card >> > > via pass(4) device -- now we can write WLAN driver in userland : >> > > -D >> > > > > Great news, userspace drivers are the best!:) >> > > > > So what are the remaining pieces that prevent this work from >> > > > > hitting >> > > the HEAD? >> > > > > -- >> > > > > Stanislav Sedov >> > > > > ST4096-RIPE >> > > > >> > > > Hi Stas, >> > > > >> > > > As I'm not a committer, someone needs to review my code and >> > > > assist in >> > > intergration into -HEAD :-) >> > > > Currently nobody was able to do a review because of -ENOTIME. >> > > > The only feature that is missing in the new stack (from my PoV) >> > > > is >> > > working with high-speed cards -- I just haven't implemented >> > > switching to >> > > high-speed mode yet. Although now it's possible to send required >> > > commands >> > > to the card and then switch controller speed -- all using >> > > camcontrol >> > > mmcsdcmd :-). >> > > > >> > > > Do you know anyone not on CC line who is able to help me with >> > > > this? Or >> > > maybe you could even find some time yourself? >> > > >> > > Hi Ilya, >> > > Could you please post the patch to phrabricator and CC the >> > > interested >> > > parties/me? >> > > >> > >> > It's been up on phab for a while. There's been some comments on it. >> > There's >> > some >> > things wrong still that I've been meaning to get bcak to Ilya on. >> > >> > When it is ready, I plan on committing this. It goes hand in hand >> > with the >> > nvme CAM stuff >> > I've been working on. >> > >> > Anybody can take a look at it: https://reviews.freebsd.org/D4761 >> > >> >> I tried to apply the SDIO patch like this: >> >> mv ~/Downloads/D4761.diff /usr/patches >> >> Then from within my build jail: >> cd /usr/src >> patch < /usr/patches/D4761.diff >> >> and I wind up with the mmc source files in my root. What should my >> working directory be when applying this patch? > > That's an annoying historical quirk of patch... for files in the > patches where the path doesn't already exist in your filesystem it just > creates the files in the current dir, unless you add -p0, which will > make it create missing directories. (-p normally tells it how many > leading dir nodes to strip from the paths found in the patches, but -p0 > is magical in that it strips nothing but creates dirs). > > -- Ian >