From owner-svn-src-stable-8@FreeBSD.ORG Fri Sep 24 06:14:18 2010 Return-Path: Delivered-To: svn-src-stable-8@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0C5611065670; Fri, 24 Sep 2010 06:14:18 +0000 (UTC) (envelope-from rpaulo@freebsd.org) Received: from karen.lavabit.com (karen.lavabit.com [72.249.41.33]) by mx1.freebsd.org (Postfix) with ESMTP id D68BC8FC0C; Fri, 24 Sep 2010 06:14:17 +0000 (UTC) Received: from d.earth.lavabit.com (d.earth.lavabit.com [192.168.111.13]) by karen.lavabit.com (Postfix) with ESMTP id 3458711B954; Fri, 24 Sep 2010 01:14:17 -0500 (CDT) Received: from 10.0.10.3 (221.163.108.93.rev.vodafone.pt [93.108.163.221]) by lavabit.com with ESMTP id XMVUNJA3PVJ2; Fri, 24 Sep 2010 01:14:17 -0500 Mime-Version: 1.0 (Apple Message framework v1081) Content-Type: text/plain; charset=us-ascii From: Rui Paulo In-Reply-To: <20100923070247.L716@delplex.bde.org> Date: Fri, 24 Sep 2010 07:14:13 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <3CC9503B-35BA-4637-8909-CBC6674ACDDA@freebsd.org> References: <201009221800.o8MI0Ze3038214@svn.freebsd.org> <20100923070247.L716@delplex.bde.org> To: Bruce Evans X-Mailer: Apple Mail (2.1081) Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-8@freebsd.org Subject: Re: svn commit: r213002 - in stable/8: include lib/libc/gen X-BeenThere: svn-src-stable-8@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 8-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Sep 2010 06:14:18 -0000 On 22 Sep 2010, at 22:08, Bruce Evans wrote: > On Wed, 22 Sep 2010, Rui Paulo wrote: >=20 >> Log: >> MFC r197804 (rwatson): >> Add basename_r(3) to complement basename(3). basename_r(3) which = accepts >> a caller-allocated buffer of at least MAXPATHLEN, rather than using = a >> global buffer. >=20 > MAXPATHLEN has been deprecated for more than 20 years. Please don't = use > it in new interfaces. A few man pages, not including basename.3, have > been updated to spell it PATH_MAX (should be {PATH_MAX}). I'm not going to fix this because the interface will most likely change = to something that doesn't require PATH_MAX. But thanks for pointing this = out. >=20 >> Note about semantics: while this interface is not POSIXy, there's >> another major platform that uses it (Android) and the semantics = between >> the two platforms are pretty much the same. >=20 > It is also not non-POSIX... >=20 >> Modified: stable/8/include/libgen.h >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- stable/8/include/libgen.h Wed Sep 22 16:54:22 2010 = (r213001) >> +++ stable/8/include/libgen.h Wed Sep 22 18:00:34 2010 = (r213002) >> @@ -36,6 +36,7 @@ >> __BEGIN_DECLS >>=20 >> char *basename(const char *); >> +char *basename_r(const char *, char *); >> char *dirname(const char *); >> #if 0 >> char *regcmp(const char *, ...); >>=20 >=20 > ...since it is declared in the POSIX namespace. I don't know of a better place to declare it. Regards, -- Rui Paulo