From owner-cvs-src@FreeBSD.ORG  Wed Aug 23 04:08:46 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3AF2116A4E0;
	Wed, 23 Aug 2006 04:08:46 +0000 (UTC)
	(envelope-from scottl@samsco.org)
Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 18A9A43D45;
	Wed, 23 Aug 2006 04:08:44 +0000 (GMT)
	(envelope-from scottl@samsco.org)
Received: from [192.168.254.11] (phobos.samsco.home [192.168.254.11])
	(authenticated bits=0)
	by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id k7N48GN0008207;
	Tue, 22 Aug 2006 22:08:21 -0600 (MDT)
	(envelope-from scottl@samsco.org)
Message-ID: <44EBD4AE.2060304@samsco.org>
Date: Tue, 22 Aug 2006 22:08:14 -0600
From: Scott Long <scottl@samsco.org>
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US;
	rv:1.7.13) Gecko/20060414
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: John Polstra <jdp@polstra.com>
References: <XFMail.20060822205444.jdp@polstra.com>
In-Reply-To: <XFMail.20060822205444.jdp@polstra.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed 
	version=3.1.1
X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org
Cc: Pyun YongHyeon <pyunyh@gmail.com>, src-committers@FreeBSD.org,
	"Patrick M. Hausen" <hausen@punkt.de>, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org, Gleb Smirnoff <glebius@FreeBSD.org>,
	Pyun YongHyeon <yongari@FreeBSD.org>
Subject: Re: cvs commit: src/sys/dev/em if_em.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Aug 2006 04:08:46 -0000

John Polstra wrote:

> On 23-Aug-2006 Pyun YongHyeon wrote:
> 
>>On Tue, Aug 22, 2006 at 07:23:33PM +0400, Gleb Smirnoff wrote:
>>I think that problem is different one. That problem happens when
>>interrupt is shared with other devices. In these configuration
>>em(4) misses lots of Tx completion interrupts and devices that
>>use the shared interrupt stop working in the long run.
>>It seems that debug.mpsafenet=0 mitigate the issue.
>>
>> > So I think there is a problem in FreeBSD or driver, not in chip.
>> > 
>>Agreed. If my memory serve me right it introduced right after
>>switching to taskqueue(9) in interrupt handling(rev, 1.98).
> 
> 
> I was wondering about something in connection with this.  The em
> interrupt handler is now a "fast" handler, but the interrupt is still
> allocated with bus_alloc_resource_any(..., RF_SHAREABLE).  If I
> remember correctly, fast interrupts cannot be shared.  So, isn't it
> wrong to allocate the interrupt with RF_SHAREABLE?
> 
> John

Fast interrupts have been sharable as of about a year ago.

Scott