From owner-freebsd-current@freebsd.org Fri Sep 29 01:29:06 2017 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 56552E12610 for ; Fri, 29 Sep 2017 01:29:06 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22a.google.com (mail-io0-x22a.google.com [IPv6:2607:f8b0:4001:c06::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1954374C83 for ; Fri, 29 Sep 2017 01:29:06 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22a.google.com with SMTP id v36so316747ioi.1 for ; Thu, 28 Sep 2017 18:29:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=wUXMC+f/deIMz+0/Ga0yAFzTvOy18I4h30HARYRaZTA=; b=0IcgK+pZiVCQlxEtkweG/mfw+soVzSd9prQcZGxZsLsSHtvmoW4yJ0Vjx1uXbO4Xl+ 6ulD0P4kO/e+yuy9JSY7RXRRvJ+0bL6S7NDH2q0q5UAZZtk6cWCi22C+V7nDV69bsNJ4 j6eC7ZQ0bA0xzoFkV4M85+E8mYY4042RSXjHwWMjqWiAGG3b9qopniKMC7r7uzAMfKhp HlkFz5dDX5CFvZ3vYPlwcGTpRDl+egPW+nv0S+qtS/QZnY22yyILG0FWTM2+Ll5mN3/c KMTl9XFZ96E6IV3I4r5v+yZmxgjhitEWQDqjHCOs90UyNpJu3JneCwpwYjM4xnvaWCyd jnUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=wUXMC+f/deIMz+0/Ga0yAFzTvOy18I4h30HARYRaZTA=; b=Ez0d0E7Lq413Ahylta9adDvStnWXBd/3TADsN94wIBlh20nAKrgxCh/4uelugpCSYJ NzzyCMNXKcrKH93RAipSn06e4PCJXc/sdAhaP0+aFlKeAGGb5ISkld+8QwyZ4DsrxU6m hFvm/gQ/+T6Qovz/bCxr1N+U40Zob1YmDcLyUJ2I/QW/dy0EOujhw2wSKWbYgaGjuTGg 5Wy7zOLOeBHjrZ4AG9DHz16DHGqbRgJSvx0RVIE0tR3ph6VInordOYxvlMfS5O2Buv6j xgMfZwMkPgEn0KfgHLOPeD3a3MbCpjCP9K5YKDR29KP/nR9c3ueyzv1/u0GGoy0ycl1s y2mw== X-Gm-Message-State: AMCzsaWx+sOpVo6I+if4UvPZzuUXYHq6Qk8PNCxkvFzqassBeIxaJort LQkdD25GrCgIEhh001uGoSKl04Nh/8Re636Zpf3XOQ== X-Google-Smtp-Source: AOwi7QD1pVKt5ckFqOJuD3le73P1jaLiIdZHT84/LNk/nPcVzY/ibwoeGB8EqrHZglw2Sw+Iy0+cNvW4xnYLGpaYn6s= X-Received: by 10.107.133.92 with SMTP id h89mr9557828iod.208.1506648545315; Thu, 28 Sep 2017 18:29:05 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.2.194 with HTTP; Thu, 28 Sep 2017 18:29:04 -0700 (PDT) X-Originating-IP: [2607:fb90:6e97:4975:0:11:542e:4401] Received: by 10.79.2.194 with HTTP; Thu, 28 Sep 2017 18:29:04 -0700 (PDT) In-Reply-To: <201709290109.v8T19oMO028898@pdx.rh.CN85.dnsmgr.net> References: <201709290109.v8T19oMO028898@pdx.rh.CN85.dnsmgr.net> From: Warner Losh Date: Thu, 28 Sep 2017 19:29:04 -0600 X-Google-Sender-Auth: gviUXHTy62pGPEavuEQNnUHeMX8 Message-ID: Subject: Re: How do GEOM_PART_* options configure geom_part_* modules?? To: "Rodney W. Grimes" Cc: FreeBSD Current , Nick Hibma , Kevin Oberman Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Sep 2017 01:29:06 -0000 On Sep 28, 2017 7:09 PM, "Rodney W. Grimes" < freebsd-rwg@pdx.rh.cn85.dnsmgr.net> wrote: > On Thu, Sep 28, 2017 at 11:12 AM, Kevin Oberman wrote: > > > On Thu, Sep 28, 2017 at 9:13 AM, Warner Losh wrote: > > > >> On Thu, Sep 28, 2017 at 10:00 AM, Nick Hibma > >> wrote: > >> > >> > I created a new kernel config file from scratch, wondered what the > >> > GEOM_PART_MBR option and friends were doing, search for them, didn't > >> find > >> > them in the tree, and deleted them from my config. But... de resulting > >> disk > >> > image didn't boot, because of the fact that it didn't recognise the MBR > >> > partitions (it only had a single diskid entry on the mount-root prompt). > >> > > >> > Can anyone explain to me how these kernel options work, as in: they are > >> > defined in kernel configs and as a consequence in opt_geom.h, but how > >> are > >> > they actually used to select which geom_part_* modules/kernel parts to > >> > build? I thought these options were translated to stuff that cpp would > >> use, > >> > but there are not uses of for example GEOM_PART_MBR anywhere for > >> example! > >> > > >> > > >> > The module always build them because they are listed in the module's > >> > Makefile. > >> > > >> > The kernel only sometimes does. Here's the key lines from conf/files: > >> > files:geom/geom_bsd_enc.c optional geom_bsd | geom_part_bsd > >> > files:geom/part/g_part_apm.c optional geom_part_apm > >> > files:geom/part/g_part_bsd.c optional geom_part_bsd > >> > files:geom/part/g_part_bsd64.c optional geom_part_bsd64 > >> > files:geom/part/g_part_ebr.c optional geom_part_ebr > >> > files:geom/part/g_part_gpt.c optional geom_part_gpt > >> > files:geom/part/g_part_ldm.c optional geom_part_ldm > >> > files:geom/part/g_part_mbr.c optional geom_part_mbr > >> > files:geom/part/g_part_vtoc8.c optional geom_part_vtoc8 > >> > > >> > which turn on/off which files get included. config "helpfully" converts > >> the > >> > upper case options to lower case for this. > >> > > >> > Warner > >> > > >> > > >> > *slaps forehead* Goose chase! > >> > > >> > I actually knew that... and, at the time, thought it was weird > >> behaviour. > >> > ''grep" would not have failed me if those options would be uppercase > >> there > >> > ... > >> > > >> > >> I've been nibbled to death by these geese often enough to have a PTSD-like > >> reaction when someone mentions it and habitually add -i to my greps... > >> > >> Warner > > > > > > This horrid POLA violation seems to have been in FreeBSD configuration > > since at least 3.0 and probably goes back to the creation of the > > configuration process. > > > > Any idea why such a horrible POLA was ever introduced? Seems like an > > obviously bad idea in an OS that is ALMOST always case sensitive. > > > > It's received code from the old 4.3 BSD config program (or maybe the net-2 > config program). We had best not have any code direct from 4.3 or net-2, it should be from 4.4BSDLite, any code prior to that is subject of the lawsuit. The code is idental in both. There is also a newconfig in 4.4 we didn't adopt... Warner -- Rod Grimes rgrimes@freebsd.org