From owner-svn-src-all@freebsd.org Tue Sep 1 14:53:11 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 62F539C8A82; Tue, 1 Sep 2015 14:53:11 +0000 (UTC) (envelope-from bjkfbsd@gmail.com) Received: from mail-vk0-x22f.google.com (mail-vk0-x22f.google.com [IPv6:2607:f8b0:400c:c05::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 27B76CE6; Tue, 1 Sep 2015 14:53:11 +0000 (UTC) (envelope-from bjkfbsd@gmail.com) Received: by vkbf67 with SMTP id f67so52673872vkb.0; Tue, 01 Sep 2015 07:53:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=faBbrJV5xw7Nchz6AvT+HBoTlqkPmKlRwttNjM2a6m0=; b=Od3i3RoPjyIPuyPqFBmOfMkLMXO8welRzQbmHVfcilcfjbRvEN80dGxriywqsF7zwv K2FwnMJLRI5i1HdUlOVtHSuIOdcwMeV0zSD/RPHdDtzMgrF2OcvOGxo19LnsACIsHEhm gcik+M3EyzX2su4FrLki4O+XdY5tSFJfmsERCPSwrOLXscfn9BnMLyTM7mj+1MbsQpPn T82bocsyGFys487WDKBeJ+XNyocHT+z6VyRbqzNb4Xblezb56ycTqkV4zG3kvVdv9kMY riFz61NLdLUrqbB+oWL3lL5+aEPT0cnO2uxDB6xpd9mn6khGymmFXBpMJn8RgIgsfShe kymw== MIME-Version: 1.0 X-Received: by 10.52.246.132 with SMTP id xw4mr31121530vdc.29.1441119190119; Tue, 01 Sep 2015 07:53:10 -0700 (PDT) Received: by 10.31.182.20 with HTTP; Tue, 1 Sep 2015 07:53:10 -0700 (PDT) In-Reply-To: <201509010834.t818YjCX089147@repo.freebsd.org> References: <201509010834.t818YjCX089147@repo.freebsd.org> Date: Tue, 1 Sep 2015 09:53:10 -0500 Message-ID: Subject: Re: svn commit: r287350 - head/lib/libc/rpc From: Benjamin Kaduk To: Craig Rodrigues Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Sep 2015 14:53:11 -0000 On Tue, Sep 1, 2015 at 3:34 AM, Craig Rodrigues wrote: > Author: rodrigc > Date: Tue Sep 1 08:34:44 2015 > New Revision: 287350 > URL: https://svnweb.freebsd.org/changeset/base/287350 > > Log: > Use ANSI C prototypes. > > Eliminates gcc 4.9 warnings. > > Modified: > head/lib/libc/rpc/auth_des.c > head/lib/libc/rpc/auth_none.c > head/lib/libc/rpc/rpcb_clnt.c > head/lib/libc/rpc/rpcdname.c > head/lib/libc/rpc/svc_auth_des.c > > Modified: head/lib/libc/rpc/auth_des.c > Not picking on Craig, since he's just building with GCC 4.9, but maybe it's time to start getting rid of auth_des and svc_auth_des? -Ben > > ============================================================================== > --- head/lib/libc/rpc/auth_des.c Tue Sep 1 08:29:39 2015 > (r287349) > +++ head/lib/libc/rpc/auth_des.c Tue Sep 1 08:34:44 2015 > (r287350) > @@ -69,7 +69,7 @@ __FBSDID("$FreeBSD$"); > > extern bool_t xdr_authdes_cred( XDR *, struct authdes_cred *); > extern bool_t xdr_authdes_verf( XDR *, struct authdes_verf *); > -extern int key_encryptsession_pk(); > +extern int key_encryptsession_pk(char *, netobj *, des_block *); > > extern bool_t __rpc_get_time_offset(struct timeval *, nis_server *, char > *, > char **, char **); > > Modified: head/lib/libc/rpc/svc_auth_des.c > > ============================================================================== > --- head/lib/libc/rpc/svc_auth_des.c Tue Sep 1 08:29:39 2015 > (r287349) > +++ head/lib/libc/rpc/svc_auth_des.c Tue Sep 1 08:34:44 2015 > (r287350) > @@ -90,11 +90,11 @@ struct cache_entry { > static struct cache_entry *authdes_cache/* [AUTHDES_CACHESZ] */; > static short *authdes_lru/* [AUTHDES_CACHESZ] */; > > -static void cache_init(); /* initialize the cache */ > -static short cache_spot(); /* find an entry in the cache */ > +static void cache_init(void); /* initialize the cache */ > +static short cache_spot(des_block *, char *, struct timeval *); /* find > an entry in the cache */ > static void cache_ref(short sid); /* note that sid was ref'd */ > > -static void invalidate(); /* invalidate entry in cache */ > +static void invalidate(char *); /* invalidate entry in cache */ > > /* > * cache statistics > @@ -353,7 +353,7 @@ _svcauth_des(struct svc_req *rqst, struc > * Initialize the cache > */ > static void > -cache_init() > +cache_init(void) > { > int i; > > @@ -376,7 +376,7 @@ cache_init() > * Find the lru victim > */ > static short > -cache_victim() > +cache_victim(void) > { > return (authdes_lru[AUTHDES_CACHESZ-1]); > } > _______________________________________________ > svn-src-all@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-all > To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" >