Date: Sat, 07 Jan 2006 23:19:29 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: gjp@in-addr.com Cc: freebsd-stable@freebsd.org Subject: Re: devd and caseful device ID matching on 6.0 Message-ID: <20060107.231929.74404461.imp@bsdimp.com> In-Reply-To: <43C0A206.6020103@in-addr.com> References: <43C09F08.1080707@freebsd.org> <20060107.221615.106545203.imp@bsdimp.com> <43C0A206.6020103@in-addr.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <43C0A206.6020103@in-addr.com>
Gary Palmer <gjp@in-addr.com> writes:
: M. Warner Losh wrote:
:
: >This works. However, matches should already be case insensitive. If
: >they aren't, then I need to investigate why not.
: >
: >
:
: My reading of regex(3) says that the reg_comp at line 173 of devd.cc
: needs to add the REG_ICASE flag. i.e.
:
: regcomp(&_regex, _re.c_str(), REG_EXTENDED | REG_NOSUB | REG_ICASE);
:
: Testing seeems to show that adding that flag makes "match" case-insensitive.
I found the same thing here, and committed a fix. Thanks! I'm still
pondering equals. I'd like to have some way to specify masks with it,
ideally, but maybe what you submitted is better enough to run with
it. As Sam mentioned, he made very similar suggestions a while ago.
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060107.231929.74404461.imp>