From owner-cvs-src@FreeBSD.ORG Wed Jun 21 09:56:36 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1AB2116A474; Wed, 21 Jun 2006 09:56:36 +0000 (UTC) (envelope-from flz@FreeBSD.org) Received: from smtp.xbsd.org (xbsd.org [82.233.2.192]) by mx1.FreeBSD.org (Postfix) with ESMTP id EE8EC43D55; Wed, 21 Jun 2006 09:56:34 +0000 (GMT) (envelope-from flz@FreeBSD.org) Received: from localhost (localhost.xbsd.org [127.0.0.1]) by smtp.xbsd.org (Postfix) with ESMTP id CB204117B3; Wed, 21 Jun 2006 11:56:31 +0200 (CEST) Received: from smtp.xbsd.org ([127.0.0.1]) by localhost (srv1.xbsd.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 78603-07; Wed, 21 Jun 2006 11:56:27 +0200 (CEST) Received: from mayday.esat.net (mayday.esat.net [193.95.134.156]) by smtp.xbsd.org (Postfix) with ESMTP id B13B51176B; Wed, 21 Jun 2006 11:56:26 +0200 (CEST) From: Florent Thoumie To: Yar Tikhiy In-Reply-To: <200606210942.k5L9gtAi060504@repoman.freebsd.org> References: <200606210942.k5L9gtAi060504@repoman.freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-f2VgSJM2jpPU+1OQobAs" Date: Wed, 21 Jun 2006 10:56:25 +0100 Message-Id: <1150883785.3467.4.camel@mayday.esat.net> Mime-Version: 1.0 X-Mailer: Evolution 2.6.2 FreeBSD GNOME Team Port X-Virus-Scanned: amavisd-new at xbsd.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc rc.subr src/share/man/man8 rc.subr.8 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jun 2006 09:56:36 -0000 --=-f2VgSJM2jpPU+1OQobAs Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Wed, 2006-06-21 at 09:42 +0000, Yar Tikhiy wrote: > yar 2006-06-21 09:42:55 UTC >=20 > FreeBSD src repository >=20 > Modified files: > etc rc.subr=20 > share/man/man8 rc.subr.8=20 > Log: > Quite a number of rc.d scripts try to load kernel modules. Many > of them do that conditionally depending on kldstat. The code is > duplicated all over, but bugs can be uniqie. > =20 > To make the things more consistent, introduce a new rc.subr function, > load_kld, which takes care of loading a kernel module conditionally. > =20 > (Found this lying for a while in my p4 branch for various hacks.) I added such a function some weeks ago (far more simple though). Talking with pjd, I've backed it out to use the somewhat straight-forward method he used in rc.d/geli. I don't have a particular feeling against your function but it uses commands that may not be available early enough (getopt, egrep). While it's easy to remove the getopt dependency (see rc.d/mdconfig), it's not the case for egrep. --=20 Florent Thoumie flz@FreeBSD.org FreeBSD Committer --=-f2VgSJM2jpPU+1OQobAs Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQBEmRfJMxEkbVFH3PQRAk+FAJ9T41KHXrh90lEgHPccb3hGYJglrwCggGU1 laPLvVeFVz5VXva11KFPHmc= =ThxQ -----END PGP SIGNATURE----- --=-f2VgSJM2jpPU+1OQobAs--