From owner-freebsd-dtrace@FreeBSD.ORG Sun Jul 28 00:56:07 2013 Return-Path: Delivered-To: dtrace@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 6FF8E124 for ; Sun, 28 Jul 2013 00:56:07 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm25-vm2.bullet.mail.gq1.yahoo.com (nm25-vm2.bullet.mail.gq1.yahoo.com [98.136.217.113]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 1CF032AFF for ; Sun, 28 Jul 2013 00:56:06 +0000 (UTC) Received: from [98.137.12.57] by nm25.bullet.mail.gq1.yahoo.com with NNFMP; 28 Jul 2013 00:50:58 -0000 Received: from [208.71.42.201] by tm2.bullet.mail.gq1.yahoo.com with NNFMP; 28 Jul 2013 00:50:58 -0000 Received: from [127.0.0.1] by smtp212.mail.gq1.yahoo.com with NNFMP; 28 Jul 2013 00:50:58 -0000 X-Yahoo-Newman-Id: 209049.9839.bm@smtp212.mail.gq1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: oy0gzGgVM1ly2Q4z6_IQKI825rIfv_84zbG.L2KIgUR5x6h AL0GwxByKdza9W_pOGj5GhPD5oNAYbFluXiJYQqap7ERuv5bk9eKsyOMe6Ju rq2.PWLlKNPTBih69JLEq4JMxQcD2EI_cI0U6Tgpldo7_nTuWWiCDeGKY1lp _ppwvOJY73UrSQuH2ochVu9zzgwjTefKlBzqQuIRR3pf3a0bCbCU7knH_Xuj Px2RQSdQLluFkBTGSEjPGZVAi9x0OgKzIMHyW23E78zutTyEdgM9php5Y.h6 .M16PbtxC740ierA5LRTTlOJqtthaToBizknqWCZGiNGeCAamN7NiGZITQLo iYAssTD16HXstRjUvlUUTZlmIagozRvhjABBqpf1w_ZnqO73L0PwP6xIMtKA ckYJfhm6jFOXLL50suHwjViLgq.T9xt9IzfC5p0fMtRWIWQcIoTnIAWOu_v2 m_LQ8mxkDoU.OlE7b_QIjTvHHvTwKpHGySOPtAzkIj_iSZ1CYrY0RTXhcRN5 SODNX79FvuAiRLaZGvEc8Godf6OHu.KqpqEzx4lYdlJivvMDqr5Jf1lJjyJE psUebTN2bE7Lte7HLufiIEH5chCrNmDVuJzNMON6w50spzHTvAdPlYEv2Sc4 ml93q_5tWPd3ULvQIk1HuAmTgWuM- X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf X-Rocket-Received: from [192.168.0.102] (pfg@190.157.126.109 with ) by smtp212.mail.gq1.yahoo.com with SMTP; 27 Jul 2013 17:50:58 -0700 PDT Message-ID: <51F46AEF.2040807@FreeBSD.org> Date: Sat, 27 Jul 2013 19:50:55 -0500 From: Pedro Giffuni User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130630 Thunderbird/17.0.7 MIME-Version: 1.0 To: Mark Johnston Subject: Re: [CFT] Fixes from illumos References: <51F2BC34.1040405@FreeBSD.org> <20130728002124.GB11294@charmander.uwaterloo.ca> In-Reply-To: <20130728002124.GB11294@charmander.uwaterloo.ca> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: dtrace@FreeBSD.org X-BeenThere: freebsd-dtrace@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "A discussion list for developers working on DTrace in FreeBSD." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Jul 2013 00:56:07 -0000 On 27.07.2013 19:21, Mark Johnston wrote: > On Fri, Jul 26, 2013 at 01:13:08PM -0500, Pedro Giffuni wrote: >> Hello; >> >> I am trying to put together the last two patches that we need to be >> (mostly) up to date with illumos. >> >> This "svn diff" patch brings back the rest of a somewhat elusive >> revision 249367 that gave us trouble before and had to be >> reverted: >> >> http://people.freebsd.org/~pfg/patches/dtrace/libdtrace-r249367.diff >> >> It should take care of the following issues: >> >> 3022 DTrace: keys should not affect the sort order when sorting by value >> 3023 it should be possible to dereference dynamic variables >> 3024 D integer narrowing needs some work >> >> Ignore the attempts to get repo copies of the tests when applying the >> patch but do report any regression or secondary issue it may cause. > I've applied the patch on my machine. I don't see any regressions in the > test suite and my basic sanity testing is going fine. > Thank you for testing, the patch was waiting in my HD for a while and I just wanted to be sure. Committed as r253725. >> After this, I would like to re-apply r249429, which should cover most >> of the remaining changes from Illumos. Still pending for review are >> some changes for Solaris zones support that very probably don't >> apply to our codebase at all. > Did you mistype that? r249429 has nothing to do with DTrace. Yes, I meant r249426, but this was already tested so I will commit it soon :). Pedro.