Date: Sat, 27 Jul 2013 19:50:55 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: Mark Johnston <markj@freebsd.org> Cc: dtrace@FreeBSD.org Subject: Re: [CFT] Fixes from illumos Message-ID: <51F46AEF.2040807@FreeBSD.org> In-Reply-To: <20130728002124.GB11294@charmander.uwaterloo.ca> References: <51F2BC34.1040405@FreeBSD.org> <20130728002124.GB11294@charmander.uwaterloo.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
On 27.07.2013 19:21, Mark Johnston wrote: > On Fri, Jul 26, 2013 at 01:13:08PM -0500, Pedro Giffuni wrote: >> Hello; >> >> I am trying to put together the last two patches that we need to be >> (mostly) up to date with illumos. >> >> This "svn diff" patch brings back the rest of a somewhat elusive >> revision 249367 that gave us trouble before and had to be >> reverted: >> >> http://people.freebsd.org/~pfg/patches/dtrace/libdtrace-r249367.diff >> >> It should take care of the following issues: >> >> 3022 DTrace: keys should not affect the sort order when sorting by value >> 3023 it should be possible to dereference dynamic variables >> 3024 D integer narrowing needs some work >> >> Ignore the attempts to get repo copies of the tests when applying the >> patch but do report any regression or secondary issue it may cause. > I've applied the patch on my machine. I don't see any regressions in the > test suite and my basic sanity testing is going fine. > Thank you for testing, the patch was waiting in my HD for a while and I just wanted to be sure. Committed as r253725. >> After this, I would like to re-apply r249429, which should cover most >> of the remaining changes from Illumos. Still pending for review are >> some changes for Solaris zones support that very probably don't >> apply to our codebase at all. > Did you mistype that? r249429 has nothing to do with DTrace. Yes, I meant r249426, but this was already tested so I will commit it soon :). Pedro.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51F46AEF.2040807>