From owner-freebsd-bugs@FreeBSD.ORG Sun Jan 25 21:20:14 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D424516A4CE for ; Sun, 25 Jan 2004 21:20:14 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5D29043D1F for ; Sun, 25 Jan 2004 21:20:13 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i0Q5KDFR040669 for ; Sun, 25 Jan 2004 21:20:13 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.10/8.12.10/Submit) id i0Q5KD5b040668; Sun, 25 Jan 2004 21:20:13 -0800 (PST) (envelope-from gnats) Date: Sun, 25 Jan 2004 21:20:13 -0800 (PST) Message-Id: <200401260520.i0Q5KD5b040668@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: "Jun Su" Subject: Re: kern/61734: [PATCH]Incorrect unit number when kldload module X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Jun Su List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jan 2004 05:20:15 -0000 The following reply was made to PR kern/61734; it has been noted by GNATS. From: "Jun Su" To: Cc: Subject: Re: kern/61734: [PATCH]Incorrect unit number when kldload module Date: Mon, 26 Jan 2004 13:10:16 +0800 This is a multi-part message in MIME format. ------=_NextPart_000_0021_01C3E40D.BDB947D0 Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Per discussion with jhb, this problem need not to fix. Please close this = PR. To document this, a better fix is that the device will not added to = parent if it is disabled. =3D=3D=3D=3D //depot/usr/junsu/mywork/isa/isahint.c#2 (text) = =3D=3D=3D=3D @@ -42,6 +42,9 @@ int sensitive, start, count, t; int order; =20 + if (resource_disabled(name, unit)) + return; + /* device-specific flag overrides any wildcard */ sensitive =3D 0; if (resource_int_value(name, unit, "sensitive", &sensitive) !=3D 0) @@ -78,9 +81,6 @@ =20 if (resource_int_value(name, unit, "flags", &t) =3D=3D 0) device_set_flags(child, t); - - if (resource_disabled(name, unit)) - device_disable(child); } ------=_NextPart_000_0021_01C3E40D.BDB947D0 Content-Type: text/html; charset="gb2312" Content-Transfer-Encoding: quoted-printable
Per discussion with jhb, this problem = need not to=20 fix. Please close this PR.
 
To document this, a better fix is that = the device=20 will not added to parent if it is disabled.
=3D=3D=3D=3D = //depot/usr/junsu/mywork/isa/isahint.c#2=20 (text) =3D=3D=3D=3D
 

@@ -42,6 +42,9=20 @@
  int  sensitive, start, count,=20 t;
  int  order;
 
+   &= nbsp;   =20 if (resource_disabled(name, unit))
+  =20 return;
+
  /* device-specific flag overrides any = wildcard=20 */
  sensitive =3D 0;
  if = (resource_int_value(name,=20 unit, "sensitive", &sensitive) !=3D 0)
@@ -78,9 +81,6=20 @@
 
  if (resource_int_value(name, unit, "flags", = &t)=20 =3D=3D 0)
   device_set_flags(child, = t);
-
- if=20 (resource_disabled(name,=20 unit))
-  device_disable(child);
 }
 
------=_NextPart_000_0021_01C3E40D.BDB947D0--