From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Nov 1 12:32:20 2004 Return-Path: Delivered-To: freebsd-ports-bugs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 39E0716A4CE; Mon, 1 Nov 2004 12:32:20 +0000 (GMT) Received: from buexe.b-5.de (buexe.b-5.de [80.148.32.30]) by mx1.FreeBSD.org (Postfix) with ESMTP id 06B4443D5A; Mon, 1 Nov 2004 12:32:19 +0000 (GMT) (envelope-from lupe@lupe-christoph.de) Received: from antalya.lupe-christoph.de (antalya.lupe-christoph.de [172.17.0.9])iA1CWHFJ022066; Mon, 1 Nov 2004 13:32:17 +0100 Received: from localhost (localhost [127.0.0.1]) by antalya.lupe-christoph.de (Postfix) with ESMTP id E54A4B886; Mon, 1 Nov 2004 13:32:11 +0100 (CET) Received: from antalya.lupe-christoph.de ([127.0.0.1]) by localhost (antalya [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 11455-02-2; Mon, 1 Nov 2004 13:32:11 +0100 (CET) Received: by antalya.lupe-christoph.de (Postfix, from userid 1000) id C228BB885; Mon, 1 Nov 2004 13:32:11 +0100 (CET) Date: Mon, 1 Nov 2004 13:32:11 +0100 From: Lupe Christoph To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org Message-ID: <20041101123211.GU7904@lupe-christoph.de> References: <20041101105609.418FD60E1@sebastian.lupe-christoph.de> <200411011100.iA1B0k8i093083@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200411011100.iA1B0k8i093083@freefall.freebsd.org> User-Agent: Mutt/1.5.6+20040722i X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at lupe-christoph.de Subject: Re: ports/73377: Update port: sysutils/munin-node 1.0.2 -> 1.0.3 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2004 12:32:20 -0000 I found PR#72104 too late. Had I received the CC Yen-Ming Lee talks about, I would never have approved his patch. The following patch undoes the damage. - remove etc/munin/VERSION.node again! Nobody reads CVS comments. This was removed in version 1.2 of this file after having been added by an overzealous committer. - add a @comment about this to prevent this from happening a third time. - re-add files unlisted by revision 1.5. I have no idea why they were missing on Yen-Ming Lee's system. Lupe Christoph --- /usr/ports/sysutils/munin-node/pkg-plist Sun Oct 31 12:50:03 2004 +++ munin-node/pkg-plist Mon Nov 1 13:24:48 2004 @@ -1,4 +1,4 @@ -etc/munin/VERSION.node +@comment etc/munin/VERSION.node must remain for upgrade version check etc/munin/munin-node.conf etc/munin/plugin-conf.d/plugins.conf etc/rc.d/munin-node.sh @@ -12,6 +12,7 @@ %%DATADIR%%/plugins/apache_volume %%DATADIR%%/plugins/apc_envunit_ %%DATADIR%%/plugins/bind9 +%%DATADIR%%/plugins/cpu %%DATADIR%%/plugins/df %%DATADIR%%/plugins/df_inode %%DATADIR%%/plugins/exim_mailqueue @@ -19,9 +20,13 @@ %%DATADIR%%/plugins/folding@home %%DATADIR%%/plugins/hddtemp %%DATADIR%%/plugins/hddtemp2 +%%DATADIR%%/plugins/if_ +%%DATADIR%%/plugins/if_errcoll_ %%DATADIR%%/plugins/ipac-ng %%DATADIR%%/plugins/ircu +%%DATADIR%%/plugins/load %%DATADIR%%/plugins/mailman +%%DATADIR%%/plugins/memory %%DATADIR%%/plugins/multips %%DATADIR%%/plugins/munin_graph %%DATADIR%%/plugins/munin_update @@ -31,12 +36,15 @@ %%DATADIR%%/plugins/mysql_slowqueries %%DATADIR%%/plugins/mysql_threads %%DATADIR%%/plugins/named +%%DATADIR%%/plugins/netstat +%%DATADIR%%/plugins/open_files %%DATADIR%%/plugins/plugins.history %%DATADIR%%/plugins/pm3users %%DATADIR%%/plugins/pop_stats %%DATADIR%%/plugins/postfix_mailqueue %%DATADIR%%/plugins/postfix_mailstats %%DATADIR%%/plugins/postfix_mailvolume +%%DATADIR%%/plugins/processes %%DATADIR%%/plugins/ps_ %%DATADIR%%/plugins/psu_ %%DATADIR%%/plugins/samba @@ -57,6 +65,7 @@ %%DATADIR%%/plugins/squid_requests %%DATADIR%%/plugins/squid_traffic %%DATADIR%%/plugins/surfboard +%%DATADIR%%/plugins/swap %%DATADIR%%/plugins/sybase_space %%DATADIR%%/plugins/vmstat @unexec rmdir %D/var/munin/plugin-state 2>/dev/null || true -- | lupe@lupe-christoph.de | http://www.lupe-christoph.de/ | | "... putting a mail server on the Internet without filtering is like | | covering yourself with barbecue sauce and breaking into the Charity | | Home for Badgers with Rabies. Michael Lucas |