Date: Tue, 28 Jun 2005 23:10:34 -0700 (PDT) From: Doug White <dwhite@gumbysoft.com> To: John Baldwin <jhb@FreeBSD.org> Cc: freebsd-current@freebsd.org, current@freebsd.org Subject: Re: Patch for sysinstall wrong-disc problem Message-ID: <20050628230944.I3088@carver.gumbysoft.com> In-Reply-To: <200506271701.45080.jhb@FreeBSD.org> References: <20050618173102.R73598@carver.gumbysoft.com> <200506271701.45080.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 27 Jun 2005, John Baldwin wrote: > On Saturday 18 June 2005 08:33 pm, Doug White wrote: > > Hey folks, > > > > I've come up with a patch that fixes sysinstall prompting for the wrong CD > > when trying to install packages from non-CDROM media. Patch is here: > > > > http://people.freebsd.org/~dwhite/patches/index.c.20050618.patch > > > > This makes the "This is disc#0; I need disc#1" type message go away by > > checking if the install media is a CDROM first. Tested with an install > > over NFS, but it shouldn't make a difference what install media as long as > > its not a CD. > > > > I'll commit this shortly if there are no objections. > > Just a suggestion: it might be a shorter patch with no need to reindent a > bunch of code if you change the patch to just add > > if (mediaDevice->type != DEVICE_TYPE_CDROM) > return (DITEM_FAILURE); > > before the while loop. That'd be wrong; I'm only trying to skip the logic that does the CDROM frobbing. I need the rest of the function so it loads the package :) Thanks for reminding me to commit this though :) -- Doug White | FreeBSD: The Power to Serve dwhite@gumbysoft.com | www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050628230944.I3088>