From owner-svn-ports-all@freebsd.org  Sat Oct 27 19:39:52 2018
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8715A10D15AE;
 Sat, 27 Oct 2018 19:39:52 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 3BE947851A;
 Sat, 27 Oct 2018 19:39:52 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id 2A7E212FBC; Sat, 27 Oct 2018 19:39:52 +0000 (UTC)
From: Jan Beich <jbeich@FreeBSD.org>
To: Johan van Selst <johans@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r482279 - head/security/libssh
References: <201810170839.w9H8dDYv096737@repo.freebsd.org>
 <y3at-agjl-wny@FreeBSD.org>
Date: Sat, 27 Oct 2018 21:39:47 +0200
Message-ID: <woq3-xjp8-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Oct 2018 19:39:52 -0000

Jan Beich <jbeich@FreeBSD.org> writes:

> Johan van Selst <johans@FreeBSD.org> writes:
>
>> Modified: head/security/libssh/pkg-plist
>> ==============================================================================
>> --- head/security/libssh/pkg-plist	Wed Oct 17 07:43:25 2018	(r482278)
>> +++ head/security/libssh/pkg-plist	Wed Oct 17 08:39:12 2018	(r482279)
>> @@ -11,10 +11,5 @@ lib/cmake/libssh/libssh/libssh-config-version.cmake
>>  %%STATIC%%lib/libssh.a
>>  lib/libssh.so
>>  lib/libssh.so.4
>> -lib/libssh.so.4.4.2
>> -%%STATIC%%lib/libssh_threads.a
>> -lib/libssh_threads.so
>> -lib/libssh_threads.so.4
>> -lib/libssh_threads.so.4.4.2
>
> Good luck unbreaking consumers:

Sorry for the tone.

Testing build of all consumers is a good practice if not mandatory for
ports/ committers unless you have a good reason like stable API/ABI. For
one, ABI tracker shows 0.8.0 removed some symbols from libssh.so and the
entirety of libssh_threads.so.

https://abi-laboratory.pro/tracker/timeline/libssh/

> http://beefy9.nyi.freebsd.org/data/112amd64-default/482319/logs/errors/remmina-1.2.31.4.log

Fixed in r483100.

> http://beefy9.nyi.freebsd.org/data/112amd64-default/482319/logs/errors/tmate-2.2.1_2.log

Fixed in r482320.

> http://beefy9.nyi.freebsd.org/data/112amd64-default/482319/logs/errors/tmate-slave-g20171113,1.log

Fixed in r482345.