From owner-freebsd-ports@FreeBSD.ORG Sat Feb 21 12:01:54 2009 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4319810656D0 for ; Sat, 21 Feb 2009 12:01:54 +0000 (UTC) (envelope-from swell.k@gmail.com) Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.186]) by mx1.freebsd.org (Postfix) with ESMTP id 9B8658FC15 for ; Sat, 21 Feb 2009 12:01:53 +0000 (UTC) (envelope-from swell.k@gmail.com) Received: by nf-out-0910.google.com with SMTP id e27so198392nfd.33 for ; Sat, 21 Feb 2009 04:01:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:references :date:in-reply-to:message-id:user-agent:mime-version:content-type; bh=v5NNOcfycbaRONCZASaZx+V5gwFzdrP7ZgHHDYKuNaI=; b=pAVeUl5fLJD6h3hXBQv8z9l1zKMRp4aU9tunwaCnedZzBCadoVSWkUuPLTVvCMWGUM gOn5i2HXlILD3WzJ38pNYfix6sRtgXrxBq2ys4YniDBYORrbQgbY2LF0L6T8T5DArYEL 3tzcnmMXptTYSU6nrA/RI54GqwPD5SBLdcftg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=X6zUaLthxCX85+29K2GzXJM60Cg2W5JZ4jMUISneHUznuE7hF2i6wYsfD1O/FVJFo8 nbj6dDOhHJroY5Gl/bQC7EmXpBI8W1BrxeLtNdPsLirgAe6mIBWFpatn+B1A9w5RnAnt Poy8Z14KdweuZDtEBTWY6kya5Bi/1Y8OyoC1o= Received: by 10.210.88.3 with SMTP id l3mr1549140ebb.20.1235217712482; Sat, 21 Feb 2009 04:01:52 -0800 (PST) Received: from localhost (93-80-43-198.broadband.corbina.ru [93.80.43.198]) by mx.google.com with ESMTPS id 28sm2061073eye.59.2009.02.21.04.01.50 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 21 Feb 2009 04:01:51 -0800 (PST) From: Anonymous To: Ion-Mihai Tetcu References: <86bpsw2tbf.fsf@gmail.com> <20090221104501.06e778f1@it.buh.tecnik93.com> Date: Sat, 21 Feb 2009 15:01:37 +0300 In-Reply-To: <20090221104501.06e778f1@it.buh.tecnik93.com> (Ion-Mihai Tetcu's message of "Sat, 21 Feb 2009 10:45:01 +0200") Message-ID: <86r61svw0u.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.90 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: freebsd-ports@freebsd.org Subject: Re: git snapshots, PORTVERSION, PORTEPOCH X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Feb 2009 12:01:58 -0000 Ion-Mihai Tetcu writes: > On Sat, 21 Feb 2009 09:32:52 +0300 > Anonymous wrote: > >> Would it be okay if I use commit hash in PORTVERSION and constantly >> bump PORTEPOCH on each update? Are there any such precedents? >> >> %%% >> PORTVERSION= 0.0.10${SNAPSUFFIX} >> PORTEPOCH= 1 >> >> SNAPSUFFIX= .${SNAPTYPE}.${SNAPREV} >> SNAPTYPE= git >> SNAPREV= e09f50e >> %%% >> >> Where PKGNAME would look like >> >> myport-0.0.10.git.e09f50e,1 >> >> I want to keep commit reference in place and refrain from using vague >> dates in PORTVERSION because there can be several commits per day. And >> for curious users I can include ChangeLog file in distfile generated >> from git-log command. > > No, please don't do this. We use PORTEPOCH when there's no other way. OK. I can include date before commit hash and drop use of PORTEPOCH. It would look like SNAPSUFFIX= .20090219.e09f50e Any other objections? > > Use, like other ports do: > PORTVERSION= 0.0.10 > PORTREVISION= ${SNAPDATE} > > I don't see what role SNAPTYPE would have. SNAPTYPE isn't neccessary, just a little convenience. > Since you have the date, you can easily get the git magic string. Dates aren't atomic. That would require precise dates up to seconds and still leave place for ambiguity. I opt to not drop git magic string if possible else talking to upstream would be a little harder.