From nobody Thu Mar 20 07:13:28 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZJGyK6GJHz5rQh2; Thu, 20 Mar 2025 07:13:29 +0000 (UTC) (envelope-from shurd@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZJGyK3bCdz3qMb; Thu, 20 Mar 2025 07:13:29 +0000 (UTC) (envelope-from shurd@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1742454809; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wEgZOzgRTtBXaerBNL+XHUEBCzjPOiqkzR6rE+5zD9o=; b=opw0WMrbpVrIx9R7YCb0Ifh30OCI9H4HaaptYRelGMQa7PEEJbqX0XhQeq3oWJCtiYhSuO iCM97RE4Zh5nHhiCRtyqVpIGoji0tIdZpGMva3ADrXDs2TXtQ5WFu+59vP5oB778YX84Wj qwovh8rmF9Fud8x817WwULz7fTBvmpHnISPilPXjgmkUyJvc+P2j0m8zbpM+Qv9+yIDRwP ETxTcmkVLK4gCsQ/G8FHlk7MdOfWVdS6thU2XVnuQkXM2UsJ+yvqEsp7YbpMC5R98+qg7e B7MSdJ4KMZj12inavkuOraM1X4xCHrJNdfwbGT1WPtwAKHpfF9qHU95AeaBwog== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1742454809; a=rsa-sha256; cv=none; b=V/vAbyY3sD6lDul8PC4B0KAP91u42Oz4EpDKeXTntsLsUtpMxwY7gXDu+dq1WByMV2t6EA JiheudibmICKB8RvXP2yBRDNuloW0mrvF1bfP/IQ78yN/uwd+U18/0eAV/tqcyU/qXoUQR SL3ult4JNXZBDJxVbHYWzZKXW5KhdJBfxTh8ZX3DVQOARUj843/Doko54F21uHsHdvLkpE OedM49Z/3QXaq0NxFbPentw9RupjxPbWrcIP+QQS/znO/tSNnpaclKi/z2J8jo7WwTPAzy ePpL2vLwZtKHxVM+noM7/+qFx0Lat7CNSUruJiNYD2EsSxuSL0dw33rvZHvrWw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1742454809; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wEgZOzgRTtBXaerBNL+XHUEBCzjPOiqkzR6rE+5zD9o=; b=FtQPlKCv1WqgnCXHb2T9VbiOwdVe98wb9ZvbyxQwyfKuFd9vfTteMVp46k05bgu340u/gZ T4x7m+ZbHk9VFW43ZImdJXjNnki55eNdWMWSOHC5kszuRfCBci+gXb1MhEmyF5UhGLOZFk /dw+q3vQyZbM6OvePFQDN7YVZBn+HoYGDGjv5uBUKEKlOYIc0aUriZYgvK+VAEXRH/4Oyh EPgPrWCFBmHzSM50H3LFH76+GWwNTDwxm+LUq/5QHeX0s0qKhVsJh0Jwi7aNFc9TVJWnXD fllvJ2kE++cIQM/x7pLEvcpka6pAI2yEQJJtrW65Jhpp3Z4P1mkgVkKD3EqOfw== Received: from [IPV6:2601:404:ce00:7c90:ec4:7aff:fec4:ac4a] (unknown [IPv6:2601:404:ce00:7c90:ec4:7aff:fec4:ac4a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: shurd) by smtp.freebsd.org (Postfix) with ESMTPSA id 4ZJGyK11C8z16T9; Thu, 20 Mar 2025 07:13:29 +0000 (UTC) (envelope-from shurd@FreeBSD.org) Message-ID: <8cc8ee54-d6ea-47dc-a22d-57b6b03bda4e@FreeBSD.org> Date: Thu, 20 Mar 2025 03:13:28 -0400 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 9d0eea9422d0 - main - Make newly POSIX functions visible To: Colin Percival , Stephen Hurd , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202503192345.52JNjFxt093046@gitrepo.freebsd.org> <01000195b231d604-edc6ae17-e5d4-4dc6-afd3-995223ecde17-000000@email.amazonses.com> <1c4b2e3e-aabc-4fd4-a115-56a9133e9bff@sjh.sh> Content-Language: en-US From: shurd@FreeBSD.org In-Reply-To: <1c4b2e3e-aabc-4fd4-a115-56a9133e9bff@sjh.sh> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2025-03-20 03:11, Stephen Hurd wrote: > On 2025-03-20 02:16, Colin Percival wrote: >> On 3/19/25 16:45, Stephen Hurd wrote: >>> commit 9d0eea9422d075c8a6924b33161d2d5abfb4072a >>> Author:     Stephen Hurd >>> AuthorDate: 2025-03-19 23:45:06 +0000 >>> Commit:     Stephen Hurd >>> CommitDate: 2025-03-19 23:45:06 +0000 >>> >>>      Make newly POSIX functions visible >>>           Some of the POSIX 202405L functions are already in the >>> system, make >>>      them visible when appropriate. >>>           Reviewed by:    imp >>>      MFC after:      1 week >>>      Differential Revision: https://reviews.freebsd.org/D47859 >> >> This broke lang/python311: >>> --- Modules/posixmodule.o --- >>> ./Modules/posixmodule.c:12907:9: error: call to undeclared function >>> 'setresuid'; ISO C99 and later do not support implicit function decla >>> rations [-Werror,-Wimplicit-function-declaration] >>>  12907 |     if (setresuid(ruid, euid, suid) < 0) >>>        |         ^ >> I realize this is almost certainly a bug in Python (assuming that these >> functions are available without setting the right POSIX level) but if >> Python has this bug I'm sure other ports will also be affected. Please >> back out this commit and talk to portmgr@ about doing an exp-run to find >> out what needs to be fixed in the ports tree before re-committing this. > > I could also make it #if __POSIX_VISIBLE >= 202405 || __BSD_VISIBLE > > Should fix the problem, but still make them visible for POSIX. https://reviews.freebsd.org/D49421