From owner-cvs-src@FreeBSD.ORG Thu Feb 14 00:16:14 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 02D0616A41B for ; Thu, 14 Feb 2008 00:16:14 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.156]) by mx1.freebsd.org (Postfix) with ESMTP id 69EAA13C4D1 for ; Thu, 14 Feb 2008 00:16:12 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: by fg-out-1718.google.com with SMTP id 16so133370fgg.35 for ; Wed, 13 Feb 2008 16:16:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; bh=dqXelKV6BZ1obHj9oQAdkSvHjhRc0aUkEQG+36CxlV4=; b=HUiKKPvMEpasA9bXW1M/7sIDD2mZGUVDYme5wwmYshQQrT71078x+3d31A+VQXJWiGZY7oLoaHaovzZ7rDz10+S0GQdpg71WGb5iN6J2B8MMcYI46QdYTDFyvBZ0V4PwYZQFoT/1UXHdEbmoc5Wpd0w+QBcqpCfz9IFT0fOx1O8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=B1+7yJjL12YfOFOfwdYqU+JJw75Ece3MQDRBpvl6Yx3LyVP1GDSyru9IwJ79+qxu4U+tX1Qz0xE4ZUYEoaguOzOGlr96unD2nrAVxmp4SJtEq/PI6TtaCVgpyxF4dA9ERb+1EgSa2qBEgdpPpEWlBD9WlDYWFuYQ9Y01aT+SGc4= Received: by 10.86.59.2 with SMTP id h2mr519432fga.78.1202948171561; Wed, 13 Feb 2008 16:16:11 -0800 (PST) Received: by 10.86.30.17 with HTTP; Wed, 13 Feb 2008 16:16:11 -0800 (PST) Message-ID: <3bbf2fe10802131616p53b2bae2ma4bccef2d8c8fb76@mail.gmail.com> Date: Thu, 14 Feb 2008 01:16:11 +0100 From: "Attilio Rao" Sender: asmrookie@gmail.com To: "John Baldwin" In-Reply-To: <200802132333.m1DNXokI060695@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200802132333.m1DNXokI060695@repoman.freebsd.org> X-Google-Sender-Auth: 0dc45bedfc49e247 Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_mutex.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Feb 2008 00:16:14 -0000 2008/2/14, John Baldwin : > jhb 2008-02-13 23:33:50 UTC > > FreeBSD src repository > > Modified files: > sys/kern kern_mutex.c > Log: > Add a couple of assertions and KTR logging to thread_lock_flags() to > match mtx_lock_spin_flags(). As I tried to pointed out in perforce, it would not be better to check against LC_SPINLOCK (and lc_flags) instead than direct comparisons with lock_class_mtx_spin ? Attilio -- Peace can only be achieved by understanding - A. Einstein