From owner-freebsd-current  Tue Jul 16 19:11:29 2002
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 59B4E37B400
	for <current@FreeBSD.ORG>; Tue, 16 Jul 2002 19:11:27 -0700 (PDT)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0BB3043E4A
	for <current@FreeBSD.ORG>; Tue, 16 Jul 2002 19:11:26 -0700 (PDT)
	(envelope-from bde@zeta.org.au)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id MAA01101;
	Wed, 17 Jul 2002 12:10:16 +1000
Date: Wed, 17 Jul 2002 12:13:59 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: W Gerald Hicks <gehicks@gehicks.dyndns.org>
Cc: Dikshie <dikshie@ppk.itb.ac.id>, <current@FreeBSD.ORG>
Subject: Re: /usr/src/dev/md  error (?)
In-Reply-To: <24A26492-9904-11D6-99DB-0030657B5F1E@gehicks.dyndns.org>
Message-ID: <20020717115641.T3327-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

On Tue, 16 Jul 2002, W Gerald Hicks wrote:

> Following patch should silence it.
> ...
> Index: src/sys/dev/md/md.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/dev/md/md.c,v
> retrieving revision 1.66
> diff -u -r1.66 md.c
> --- src/sys/dev/md/md.c 24 Jun 2002 12:07:02 -0000      1.66
> +++ src/sys/dev/md/md.c 16 Jul 2002 21:32:44 -0000
> @@ -606,6 +606,7 @@
>                          error = mdstart_swap(sc, bp);
>                          break;
>                  default:
> +                       error = -1;
>                          panic("Impossible md(type)");
>                          break;
>                  }

This change and the break after the panic() are bogus.  panic() "never"
returns, and the compiler knows this.  Unfortunately, the RESTARTABLE_PANICS
option subverts the semantics of panic(), so panic() sometimes returns.
This breaks compilation of md.c and 28 other files in NOTES.  The fix
shouldn't be to disturb the usual flow of control in those 29 files.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message