From owner-freebsd-ports@FreeBSD.ORG Sat Aug 28 20:45:56 2010 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 76CC9106566B; Sat, 28 Aug 2010 20:45:56 +0000 (UTC) (envelope-from swell.k@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id CD1D98FC13; Sat, 28 Aug 2010 20:45:55 +0000 (UTC) Received: by fxm4 with SMTP id 4so3038179fxm.13 for ; Sat, 28 Aug 2010 13:45:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:references :date:in-reply-to:message-id:user-agent:mime-version:content-type; bh=qxea4LpLRHfRz7hv8cojJ2s5e0Xmr0eCVT+iCkhzmrc=; b=MlBr6h0Rt9OloM4RSWPkL3mDTxgEqjFkFy0OocEK+JWhrnjYvaH3k3mF3KWyEl5x25 0EWAbCK1nC+Pu/ylPGgYaMj7x99rv6WAAWKMFU0WJpkfnl7kwPrpCUH0S+rgxQi7lw6a 1ojAK6Z/DsDNJKYSxYItoGvjEnGq7xYabrxnY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=ULLWZYnwmSlMkOCZOgT6X5S4y/lyw2ulkJBwAzWgbSFXLzTXINzrwlynZ+hyWDWFik oATYOFppzshDVXumOzp/n5024ddJcxwQ8yE7dCmW6FdaD91MxmlJMFrR8jjI3oBF0ABD LB5YKpYFMqMa9V3V8jQJp3fVGCC0lvSq2Mm8c= Received: by 10.223.119.143 with SMTP id z15mr18343faq.61.1283028354752; Sat, 28 Aug 2010 13:45:54 -0700 (PDT) Received: from localhost (tor-exit-proxy1-readme.formlessnetworking.net [208.53.142.37]) by mx.google.com with ESMTPS id b9sm2570251faq.31.2010.08.28.13.45.50 (version=SSLv3 cipher=RC4-MD5); Sat, 28 Aug 2010 13:45:54 -0700 (PDT) From: Anonymous To: Greg Lewis References: <201006251808.29467.naylor.b.david@gmail.com> <861vazh881.fsf@gmail.com> <8662z58gid.fsf@gmail.com> <201008281428.06609.naylor.b.david@gmail.com> <20100828184017.GA78278@misty.eyesbeyond.com> Date: Sun, 29 Aug 2010 00:44:39 +0400 In-Reply-To: <20100828184017.GA78278@misty.eyesbeyond.com> (Greg Lewis's message of "Sat, 28 Aug 2010 11:40:17 -0700") Message-ID: <86lj7q31s8.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Greg Lewis , David Naylor , freebsd-ports@freebsd.org Subject: Re: MAKE_JOBS and openjdk6 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Aug 2010 20:45:56 -0000 Greg Lewis writes: > I would argue that overriding a private variable is a hack (other ports > doing it doesn't make it not a hack). You could've spoke up in ports/148754 about your concern in order for portmgr@ to notice. The PR strived to be less intrusive than divorcing build jobs from make jobs. Besides, I think adding more clutter to Makefiles defeats purpose of having stuff in bsd.port.mk. > Alternative patch attached which seems to achieve the same result from > my perspective without overriding _MAKE_JOBS. Hardcoding kern.smp.cpus and ignoring MAKE_JOBS_SAFE/UNSAFE doesn't seem like a less hacky solution. I'd argue that it's more confusing because MAKE_JOBS_UNSAFE is not equal to DISABLE_MAKE_JOBS. > Index: Makefile > =================================================================== > RCS file: /var/fcvs/ports/java/openjdk6/Makefile,v > retrieving revision 1.28 > diff -u -r1.28 Makefile > --- Makefile 15 Aug 2010 05:23:06 -0000 1.28 > +++ Makefile 28 Aug 2010 18:27:44 -0000 > @@ -147,8 +147,14 @@ > USE_DISPLAY= yes > .endif > -BUILD_JOBS_NUMBER!= ${SYSCTL} -n kern.smp.cpus > +.if !defined(DISABLE_MAKE_JOBS) > +.if defined(MAKE_JOBS_NUMBER) > +BUILD_JOBS_NUMBER= ${MAKE_JOBS_NUMBER} > +.else > +BUILD_JOBS_NUMBER= `${SYSCTL} -n kern.smp.cpus` > +.endif > MAKE_ENV+= HOTSPOT_BUILD_JOBS=${BUILD_JOBS_NUMBER} > +.endif > COPYDIRS= \ > hotspot/src/os/linux/launcher \