From owner-freebsd-gnome@FreeBSD.ORG Sat Apr 8 03:54:07 2006 Return-Path: X-Original-To: freebsd-gnome@freebsd.org Delivered-To: freebsd-gnome@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8D2F016A401; Sat, 8 Apr 2006 03:54:07 +0000 (UTC) (envelope-from marcus@marcuscom.com) Received: from creme-brulee.marcuscom.com (creme-brulee.marcuscom.com [24.172.16.118]) by mx1.FreeBSD.org (Postfix) with ESMTP id CC71F43D45; Sat, 8 Apr 2006 03:54:06 +0000 (GMT) (envelope-from marcus@marcuscom.com) Received: from shumai.marcuscom.com (shumai.marcuscom.com [192.168.1.4]) by creme-brulee.marcuscom.com (8.13.6/8.13.6) with ESMTP id k383sNZI083159; Fri, 7 Apr 2006 23:54:23 -0400 (EDT) (envelope-from marcus@marcuscom.com) From: Joe Marcus Clarke To: Norikatsu Shigemura In-Reply-To: <20060408115043.01ccceb9.nork@FreeBSD.org> References: <20060408115043.01ccceb9.nork@FreeBSD.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-/u249vYqL+nSJLZvKViK" Organization: MarcusCom, Inc. Date: Fri, 07 Apr 2006 23:54:03 -0400 Message-Id: <1144468443.30655.14.camel@shumai.marcuscom.com> Mime-Version: 1.0 X-Mailer: Evolution 2.4.2.1 FreeBSD GNOME Team Port Cc: oliver@freebsd.org, freebsd-gnome@freebsd.org Subject: Re: How to install sylpheed.desktop by ports system? X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Apr 2006 03:54:07 -0000 --=-/u249vYqL+nSJLZvKViK Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Sat, 2006-04-08 at 11:50 +0900, Norikatsu Shigemura wrote: > Hi gnome ports maintainers! >=20 > I have a problem about mail/sylpheed2 (based mail/sylpheed2-devel). > It's a WITH_GNOME knob. I didn't know how to install sylpheed.desktop > if GNOME is installed. But I noticed how to fix it. However, :-), > I don't know that following patch is good or bad. >=20 > So please review it. This is good, but really, gnomehier should not be used directly by non-Desktop modules. I think you want gnomeprefix. So: .if ${HAVE_GNOME:Mgnomehier}!=3D"" USE_GNOME+=3D gnomeprefix ... gnomeprefix does other magical things to ensure DATADIR is properly set. That said, you can certainly add desktop files to share/applications, and GNOME (and KDE) will pick them up. In that case, you don't need any fnacy GNOME detection at all. Just be sure to conditionally remove share/applications. Joe --=20 PGP Key : http://www.marcuscom.com/pgp.asc --=-/u249vYqL+nSJLZvKViK Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQBENzPbb2iPiv4Uz4cRAjL/AKCsaNVKJavvaMzQt2NtAvedTOUfvgCfUeW4 3TIrRotz+lFycBkQvuEsQuY= =W77K -----END PGP SIGNATURE----- --=-/u249vYqL+nSJLZvKViK--