From owner-svn-ports-all@freebsd.org Sun Feb 18 04:55:58 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BDB57F10DCE; Sun, 18 Feb 2018 04:55:57 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 1828782832; Sun, 18 Feb 2018 04:55:56 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with ESMTPA id nH0senqhF7GjanH0teZZmD; Sat, 17 Feb 2018 21:55:49 -0700 X-Authority-Analysis: v=2.3 cv=I59Luuog c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=kj9zAlcOel0A:10 a=Op4juWPpsa0A:10 a=xfDLHkLGAAAA:8 a=6I5d2MoRAAAA:8 a=w2PP7KgtAAAA:8 a=YxBL1-UpAAAA:8 a=kNc4dBCZTthV13if2wUA:9 a=CjuIK1q_8ugA:10 a=IfaqVvZgccqrtc8gcwf2:22 a=IjZwj45LgO3ly-622nXo:22 a=CDB6uwv3NW-08_pL9N3q:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 147E7A8; Sat, 17 Feb 2018 20:55:46 -0800 (PST) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id w1I4tj03058959; Sat, 17 Feb 2018 20:55:45 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id w1I4tjXX058950; Sat, 17 Feb 2018 20:55:45 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201802180455.w1I4tjXX058950@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Sunpoet Po-Chuan Hsieh cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r462121 - head/lang/ruby25 In-Reply-To: Message from Sunpoet Po-Chuan Hsieh of "Sat, 17 Feb 2018 20:06:15 +0800." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sat, 17 Feb 2018 20:55:45 -0800 X-CMAE-Envelope: MS4wfB3bYHxlbwxvro7CWb7GXqEWba5jTtpt7isjVDbVitVfialmd0kwTrzKTCTx6EFaBaMqUUEcWVqwUEH0PMCfJ/mk9P3eyLS+RYxnwQRlQtcnfudVGA8v mDJ3ngVxQekHYXQOJTwvwETAt0fQEXMtBOj/rOGY0PcuDkus7Lx4yhehlerz4sk2WvIe/xWCY5eMRPyXLCEky5JXsMXYbTtWiL6GNn78JWGdNiNhoISkcdx3 qc4WI7QlnAdkhvsLH6K+Gh+lVJPIDXiz+fdWxEunsm96BRX1qzDV4NGdu+IeU/LtRaowsiCjNquWetbJ+vA57w== X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Feb 2018 04:55:58 -0000 In message , Sunpoet Po-Chuan Hsieh writes: > --001a113fd9a81216cf0565674c82 > Content-Type: text/plain; charset="UTF-8" > > Sorry for the wrong commit log. It should be "Fix typo". This comment is fine for the mailing list but anyone looking through the commit logs a year from now will scratch their head wondering WTF. Can you revert this commit, please, and recommit it with the correct commit log message? > > On Sat, Feb 17, 2018 at 7:59 PM, Sunpoet Po-Chuan Hsieh > wrote: > > > Author: sunpoet > > Date: Sat Feb 17 11:59:12 2018 > > New Revision: 462121 > > URL: https://svnweb.freebsd.org/changeset/ports/462121 > > > > Log: > > Remove unnecessary patches > > > > We do not need to patch those files which will be regenerated during > > build. > > > > Reference: https://bugs.ruby-lang.org/issues/14261 > > PR: 225470 > > > > Modified: > > head/lang/ruby25/Makefile > > > > Modified: head/lang/ruby25/Makefile > > ============================================================ > > ================== > > --- head/lang/ruby25/Makefile Sat Feb 17 11:59:07 2018 (r462120) > > +++ head/lang/ruby25/Makefile Sat Feb 17 11:59:12 2018 (r462121) > > @@ -141,7 +141,7 @@ post-patch: > > post-build: > > # > > # Hack to allow modules to be installed into separate PREFIX and/or under > > user > > -# privilegies > > +# privileges > > # > > @${RB_SET_CONF_VAR} "prefix" "ENV['PREFIX'] || \3" > > @${RB_SET_CONF_VAR} "INSTALL" "'/usr/bin/install -c'" > > -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.