Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 23 May 1998 12:00:36 -0700
From:      Studded <Studded@san.rr.com>
To:        ac199@hwcn.org
Cc:        Ruslan Ermilov <ru@ucb.crimea.ua>, Niall Smart <njs3@doc.ic.ac.uk>, Poul-Henning Kamp <phk@FreeBSD.ORG>, nick@foobar.org, freebsd-bugs@FreeBSD.ORG
Subject:   Re: Problem reports closed by Poul-Henning Kamp [was: Re: misc/6712]
Message-ID:  <35671CD4.7DA01D1@san.rr.com>
References:  <Pine.BSF.3.96.980523105454.286A-100000@localhost>

next in thread | previous in thread | raw e-mail | index | archive | help
Tim Vanderhoek wrote:
> 
> On Sat, 23 May 1998, Ruslan Ermilov wrote:
> 
> > A number of my PRs with patches made against RELENG_2_2 were
> > committed into -current only, and these PRs were then closed.
> 
> I think then that the submitter should bug whoever committed the
> fix to commit the patches to -stable, too.

	I think the commentary is more along the lines of there being a problem
with a PR being closed at all just because it's fixed in -Current. I
have suggested that there be a new state for PR's that have been fixed
in -Current and awaiting a commit to -Stable. In the cases where it is a
trivial fix the person closing the PR should be responsible for
committing it both places. If it's something that needs testing first
the PR should be placed in the "waiting to commit to -Stable" state and
a committer who runs -Stable should deal with it. 

	Relying on a "merge mega-commit" before the next -Stable release is
just bad planning. We have enough things that need to be tested in
-Stable during the general course that we don't need to rely on last
minute merges to take care of things that should be dealt with one at a
time.

	Additionally, I bug people to commit things to -Stable all the time. I
even do the testing for them. My success rate is about 50%. The other
50% often don't even bother to respond. Relying on the "nag the
committers" strategy puts an additional and unnecessary burden on the
people who've already gone out of their way to find and implement a fix. 

Doug
-- 
***         Chief Operations Officer, DALnet IRC network       ***
***   Proud designer and maintainer of one of the world's largest
*** Internet Relay Chat server with 5,328 simultaneous connections
***   Try spider.dal.net on ports 6662-4    (Powered by FreeBSD)

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?35671CD4.7DA01D1>