From owner-freebsd-arch Sat Mar 16 4:11: 0 2002 Delivered-To: freebsd-arch@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by hub.freebsd.org (Postfix) with ESMTP id 6554937B402 for ; Sat, 16 Mar 2002 04:10:56 -0800 (PST) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.2/8.12.2) with ESMTP id g2GCAoUD037368; Sat, 16 Mar 2002 13:10:51 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: Bruce Evans Cc: "M. Warner Losh" , des@ofug.org, arch@FreeBSD.ORG Subject: Re: HEADS UP: caddr_t sweep In-Reply-To: Your message of "Sat, 16 Mar 2002 23:00:38 +1100." <20020316225716.I28305-100000@gamplex.bde.org> Date: Sat, 16 Mar 2002 13:10:50 +0100 Message-ID: <37367.1016280650@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <20020316225716.I28305-100000@gamplex.bde.org>, Bruce Evans writes: >On Fri, 15 Mar 2002, M. Warner Losh wrote: > >> In message: >> Dag-Erling Smorgrav writes: >> : I'm preparing a sweep that will remove incorrect caddr_t casts in >> : copy{in,out,str,instr}(), bcopy() and bzero() calls in the kernel. >> ... >> >> i'd like to take a look at this patch before you commit it please. >> There are many driver uses of bcopy that are non-obvious and likely >> should be bus_space_read instead... > >Maybe limit it to copy* and other userland interfaces (mmap?) then. >There are also some bcopies which should be struct assignments. I would like the argument in ioctl funtions to either become a void * argument or for caddr_t to become a void *. I did a testshot on LINT with caddr_t as a void * and the fallout is surprisingly moderate. That said, any journey starts with the first step so rather than hold up DES, I think DES should go ahead, and Warner can look for busspace_ improvements in a separate commit and Bruce can look for struct assignments in a separate sweep. I suspect that DES' patch is pretty much program generated anyway, so I don't see a value to "polluting" it with manual fixups. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message