From owner-svn-ports-head@FreeBSD.ORG  Mon Dec  3 10:56:22 2012
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 97148AB6;
 Mon,  3 Dec 2012 10:56:22 +0000 (UTC)
 (envelope-from gahr@FreeBSD.org)
Received: from cpanel09.rubas.ch (cpanel09.rubas.ch [195.182.222.79])
 by mx1.freebsd.org (Postfix) with ESMTP id 3F4138FC14;
 Mon,  3 Dec 2012 10:56:21 +0000 (UTC)
Received: from 98-41.199-178.cust.bluewin.ch ([178.199.41.98]:61679
 helo=gahrfit.gahr.ch)
 by cpanel09.rubas.ch with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256)
 (Exim 4.80) (envelope-from <gahr@FreeBSD.org>)
 id 1TfThD-000IID-QW; Mon, 03 Dec 2012 11:56:20 +0100
Date: Mon, 3 Dec 2012 11:56:16 +0100
From: Pietro Cerutti <gahr@FreeBSD.org>
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Subject: Re: svn commit: r308132 - head/audio/amrcoder
Message-ID: <20121203105616.GA86596@gahrfit.gahr.ch>
References: <201212031034.qB3AYpkL004754@svn.freebsd.org>
 <20121203105040.GA30670@FreeBSD.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="ew6BAiZeqk4r7MaW"
Content-Disposition: inline
In-Reply-To: <20121203105040.GA30670@FreeBSD.org>
X-PGP-Key: 0x9571F78E
X-PGP-Fingerprint: 1203 92B5 3919 AF84 9B97 28D6 C0C2 6A98 9571 F78E
User-Agent: Mutt/1.5.21 (2010-09-15)
X-AntiAbuse: This header was added to track abuse,
 please include it with any abuse report
X-AntiAbuse: Primary Hostname - cpanel09.rubas.ch
X-AntiAbuse: Original Domain - freebsd.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - FreeBSD.org
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: gahr@FreeBSD.org
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 03 Dec 2012 10:56:22 -0000


--ew6BAiZeqk4r7MaW
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 2012-Dec-03, 10:50, Alexey Dokuchaev wrote:
> On Mon, Dec 03, 2012 at 10:34:51AM +0000, Pietro Cerutti wrote:
> > New Revision: 308132
> > URL: http://svnweb.freebsd.org/changeset/ports/308132
> >=20
> > @@ -23,4 +18,7 @@ MANCOMPRESSED=3D	yes
> >  post-extract:
> >  	@${RM} ${WRKSRC}/*.o
> > =20
> > +post-patch:
> > +	${REINPLACE_CMD} -e 's|O4|O3|' ${WRKSRC}/${MAKEFILE}
> > +
>=20
> I recall this is not the first similar fix.  Is there reason not to uphold
> ${CFLAGS} here instead?

CFLAGS as set by the user are used:

cc -O2 -pipe -fno-strict-aliasing  -O3 -I/src -DVAD1 -std=3Dgnu99
-Qunused-arguments -fstack-protector  -c decoder.c

I see no reason, however, not to let the author supersede them with more
appropriate flags.

--=20
Pietro Cerutti
The FreeBSD Project
gahr@FreeBSD.org

PGP Public Key:
http://gahr.ch/pgp

--ew6BAiZeqk4r7MaW
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)

iEYEARECAAYFAlC8hU8ACgkQwMJqmJVx945zuwCdE1QSgOSmTQd3MyeRQqVV9R4V
KhYAnjLGGiV4q+u8tjt/B/xTaR8M6bd0
=hcHF
-----END PGP SIGNATURE-----

--ew6BAiZeqk4r7MaW--