From owner-cvs-all@FreeBSD.ORG Sun Jan 18 22:27:01 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CE9B016A4D0 for ; Sun, 18 Jan 2004 22:27:01 -0800 (PST) Received: from root.org (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 9D4AF43D45 for ; Sun, 18 Jan 2004 22:26:57 -0800 (PST) (envelope-from nate@root.org) Received: (qmail 89611 invoked by uid 1000); 19 Jan 2004 06:26:59 -0000 Date: Sun, 18 Jan 2004 22:26:59 -0800 (PST) From: Nate Lawson To: Maxim Sobolev In-Reply-To: <20040118210712.2B8C616A528@hub.freebsd.org> Message-ID: <20040118220400.M89515@root.org> References: <20040118210712.2B8C616A528@hub.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 p4tcc.c src/sys/conf files.i386 options.i386 src/sys/i386/conf NOTES X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Jan 2004 06:27:02 -0000 On Sun, 18 Jan 2004, Maxim Sobolev wrote: > FreeBSD src repository > > Modified files: > sys/conf options.i386 files.i386 > sys/i386/conf NOTES > Added files: > sys/i386/i386 p4tcc.c > Log: > Add new CPU_ENABLE_TCC option, from NOTES: > > CPU_ENABLE_TCC enables Thermal Control Circuitry (TCC) found in some > Pentium(tm) 4 and (possibly) later CPUs. When enabled and detected, > TCC allows to restrict power consumption by using machdep.cpuperf* > sysctls. This operates independently of SpeedStep and is useful on > systems where other mechanisms such as apm(4) or acpi(4) don't work. > > Given the fact that many, even modern, notebooks don't work properly > with Intel ACPI, this is indeed very useful option for notebook owners. > > Obtained from: OpenBSD > MFC after: 2 weeks I can't seem to see where this was posted before committing. Please coordinate power/thermal management code with me. I have an upcoming cpufreq driver that will encapsulate all of these machdep CPU control drivers, including SpeedStep and LongRun. It's not dependent on ACPI although ACPI can use it for passive cooling. Also, your driver should use /etc/power_profile to set a sysctl, not proliferate performance/economy sysctls. Drop me a private email and we can figure out how to coordinate. -Nate