From owner-soc-status@freebsd.org Tue Jun 6 00:41:38 2017 Return-Path: Delivered-To: soc-status@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BF895B7DCCD for ; Tue, 6 Jun 2017 00:41:38 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9503574C8E for ; Tue, 6 Jun 2017 00:41:38 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id EA7C85A9F12; Tue, 6 Jun 2017 00:41:30 +0000 (UTC) Date: Tue, 6 Jun 2017 00:41:30 +0000 From: Brooks Davis To: Miles Fertel Cc: soc-status@freebsd.org Subject: Re: Week 1 Update: Mergesort Tests Message-ID: <20170606004130.GC14665@spindle.one-eyed-alien.net> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="YiEDa0DAkWCtVeE4" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.2 (2017-04-18) X-BeenThere: soc-status@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Summer of Code Status Reports and Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jun 2017 00:41:38 -0000 --YiEDa0DAkWCtVeE4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable I got an invite from github, but even when I was definitely logged in, I got 404 errors accessing it. As a practical matter, your repo needs to be public as that's part of the terms from Google. -- Brooks On Mon, Jun 05, 2017 at 09:53:00AM -0400, Miles Fertel wrote: > Hey Brooks, >=20 > Just wanted to let you know that I've pushed my first week of work to the > github repo and added you as a collaborator. I've submitted a pull request > from the dev branch to the master and started a review with a question or > two. >=20 > I've edited mergesort_test.c to have a good first implementation, includi= ng > tests for: >=20 > - Trivial arrays > - Sorted arrays > - Partially sorted arrays > - Randomly generated arrays > - Arrays with char elements >=20 > I've built this up on top of the previous implementation, so the Kyuafile > is the same. I ran the implementation locally with atf and kyua and the > current mergesort behaves as expected, succeeding all all tests except for > the small element test. When my improved algorithm is complete, that shou= ld > pass as well. >=20 > Please let me know if there's anything I could improve. >=20 > - Miles --YiEDa0DAkWCtVeE4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJZNfo6AAoJEKzQXbSebgfArykH/izzkt73Smuqrz8fPJ0ud83Y TKCHWzPGlW8KjMwjMZ2klRU59b0V2y25xchqcgo5Pou7mC5iC3cdj0TSpIsqgiRD YuXY7w+EFJyAKx9Kk1nNtC8jdwzwJ1yrIjB3inFNsW9VC+vq3ZUaiIUo/yCQfslP qW8km1Ee0QmkDItYHVr5vCylUzRjde3QUJM5UgsX+jag5uPt+3jSatksJed6JpzX 9H7LFkr+NndJzH8us9qFm7Z+U/NrruSKIKKXygZ82G9MD0uWEOzDfIRWF3v2ZXw7 OBnnEw0yN+sUtmBt8Hh9R+SIF+TWc4fUJ8LHrQhZqlWgMOgXCgjNVunmlcXrfWg= =7C3I -----END PGP SIGNATURE----- --YiEDa0DAkWCtVeE4--