From owner-freebsd-fs@freebsd.org Thu Jul 9 16:34:13 2015 Return-Path: Delivered-To: freebsd-fs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2A61A996EF4 for ; Thu, 9 Jul 2015 16:34:13 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wi0-x22f.google.com (mail-wi0-x22f.google.com [IPv6:2a00:1450:400c:c05::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B5EBA1B2A; Thu, 9 Jul 2015 16:34:12 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by widjy10 with SMTP id jy10so249852583wid.1; Thu, 09 Jul 2015 09:34:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=YtK2sJIfQ+Sm9hCzYlWt8znOTG9GsZCsjxGJRzQ2Ifo=; b=SOXOX1UCzwVedhwsvikg5uNyfsO3fFJm+jLhwlgaB/FQ3IrHVS2IKLf3K1fDojXhF7 /wm1bjNaIKmMG8wqs6wEYz25osyv6T/ZyifbpruP7w+d2s6E1KrZ+XCPTWodfYMtJiPU T1FIm25QbOWEQWcQDux24WxF9qT89b3qxKIzgXPIdCE3LZQtdJ+NN/LBej9NkG5/pqfx 1PBd/eO7Nd2QxDvXP/hMz73Bu9uQ2WSpT4xFc4Fbu6LInEzqeMrPblGAxQRowQzfDwEs 1rfTtuWNxlXUytXH3834qJ77UMFn1Iqatxuvt1fV3o+O3AEGp/bEK4mhkGiTX7KxhjPw HbMA== X-Received: by 10.180.81.38 with SMTP id w6mr91841210wix.14.1436459651220; Thu, 09 Jul 2015 09:34:11 -0700 (PDT) Received: from dft-labs.eu (n1x0n-1-pt.tunnel.tserv5.lon1.ipv6.he.net. [2001:470:1f08:1f7::2]) by smtp.gmail.com with ESMTPSA id um5sm9636001wjc.1.2015.07.09.09.34.09 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 09 Jul 2015 09:34:10 -0700 (PDT) Date: Thu, 9 Jul 2015 18:34:07 +0200 From: Mateusz Guzik To: Konstantin Belousov Cc: rwatson@FreeBSD.org, freebsd-fs@freebsd.org Subject: Re: [PATCH 3/4] vfs: simplify error handling in namei Message-ID: <20150709163407.GD1718@dft-labs.eu> References: <20150707085857.GZ2080@kib.kiev.ua> <1436393231-5831-1-git-send-email-mjguzik@gmail.com> <1436393231-5831-4-git-send-email-mjguzik@gmail.com> <20150709102533.GO2080@kib.kiev.ua> <20150709154021.GC1718@dft-labs.eu> <20150709155345.GQ2080@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150709155345.GQ2080@kib.kiev.ua> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jul 2015 16:34:13 -0000 On Thu, Jul 09, 2015 at 06:53:45PM +0300, Konstantin Belousov wrote: > On Thu, Jul 09, 2015 at 05:40:21PM +0200, Mateusz Guzik wrote: > > On Thu, Jul 09, 2015 at 01:25:33PM +0300, Konstantin Belousov wrote: > > > On Thu, Jul 09, 2015 at 12:07:10AM +0200, Mateusz Guzik wrote: > > > > From: Mateusz Guzik > > > > > > > > The logic is reorganised so that there is one exit point prior to the > > > > lookup loop. This is an intermediate step to making audit logging > > > > functions use found vnode instead of translating ni_dirfd on their own. > > > > > > > > ni_startdir validation is removed. The only in-tree consumer is nfs > > > > which already makes sure it is a directory. > > Looks fine. > Thanks, went in as https://svnweb.freebsd.org/base?view=revision&revision=285326 -- Mateusz Guzik