From owner-svn-ports-all@freebsd.org Sat Mar 20 03:37:12 2021 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DC98A57101B; Sat, 20 Mar 2021 03:37:12 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F2RK45xwxz4rqq; Sat, 20 Mar 2021 03:37:12 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1616211432; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PIF6N1WB970OC+0Gh7kJPkiEZtG/0NWwnwRcYn4hbK8=; b=fMhImEm8PLVunii+v4HqJDYQMmHRt618O58HXwe662UJDJN2PA1Jj8lJx6xQWA9LsO5hy+ vn5zE8GXXA+qoGpdQ/nNXyJ6VMbzyqqafrQn55su51jcuRB/xdMKfhEqLZVcz0x5qlsHUb 0PHMA6x9U+2TfT6NiuPFoMPI5GvVS7tJ6599qUqNbR+KZEJMmQjpo5TceaHxCGbWLOllH/ imhLoJjqfd/qowMjW2hKDEoFuW9C7nKV49dacMeyNQr00TkdbyQx0t9rzB6tBK4JX3KPHb MJQfbnaG2t2k8VHAyDpjeQgDQFYcWDDQ8OPrdTVjyV0FQ/W+lfHnDngioehz8g== Received: by freefall.freebsd.org (Postfix, from userid 1033) id B31FC833; Sat, 20 Mar 2021 03:37:12 +0000 (UTC) Date: Sat, 20 Mar 2021 03:37:12 +0000 From: Alexey Dokuchaev To: Gleb Popov Cc: ports-committers , svn-ports-all , svn-ports-head Subject: Re: svn commit: r568794 - in head/multimedia/pipewire: . files Message-ID: <20210320033712.GA18472@FreeBSD.org> References: <202103191336.12JDaj8i012572@repo.freebsd.org> <20210319174447.GA16542@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1616211432; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PIF6N1WB970OC+0Gh7kJPkiEZtG/0NWwnwRcYn4hbK8=; b=jzq5GT/lvDpF27FFhD8Ct04ySV3xO152I8GiP+UGvB1po3CtX/cRryXjOulS0pGPoUQvAD 046gA5ULlo6iRiItlsh1RCN5tkE7PBjRdKS9jprgykccLlhUHztOzUTK1Hp+2/0YdZEC1I AhDUIxEDqi41L+QYjUfp14dJLJqrtT9iOL4q+NHuY/J1QMupJ8a+OfsoSJwX9BYExqcK/E 6MaA1S/weMUju0Ai8Qh8srK7Q+2t/kc9znHXO9/mEZTBKLY7qH68ttZUv/wW8seeq3VVcz xLgmKbvDi/dCmoB0qrlJ6jhM4FwrySnnCYwhXV9n+8Eu1sicgFA4VOZUTTLdYA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1616211432; a=rsa-sha256; cv=none; b=BKlFJ4xr8/sUHvWRooFFFD8k0xqfmrDG6m3WMp/6iidxbfpY/jkr7Uh/T/zphtoOg2omaU nwjRY5Ye9ng1rr9VbH4eyPqu9qeHAxRgtIhj7gfIhQGGS5S3ef/FBFYEJRgn2SDWI8qtyX wlWDo7jOBuHIbAHyeoMNtZHvQZGYhirHesq4OY5N2EH/ElLc9fH0IxvkCUYocZo8+Dvsrm W7SssMP/0CkMKOIGK9ftOUAq7QiRufXVqsDD5y1zYGePDhNvvgnbmKs/nmUVi3u/hw55Cj zP3q7ms+a99iO2kjasjmf98e78JD3SsFD1usRiWQWDCmgF/H5g/ke3vU2IjqDg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Mar 2021 03:37:12 -0000 On Fri, Mar 19, 2021 at 10:16:35PM +0300, Gleb Popov wrote: > On Fri, Mar 19, 2021 at 8:44 PM Alexey Dokuchaev wrote: > > On Fri, Mar 19, 2021 at 01:36:45PM +0000, Gleb Popov wrote: > > > New Revision: 568794 > > > URL: https://svnweb.freebsd.org/changeset/ports/568794 > > > > > > Log: > > > multimedia/pipewire: Fix a runtime crash. > > > > > > ... > > > @@ -0,0 +1,10 @@ > > > +--- src/daemon/pipewire.c.orig 2021-03-04 15:21:21 UTC > > > ++++ src/daemon/pipewire.c > > > +@@ -25,6 +25,7 @@ > > > + #include > > > + #include > > > + #include > > > ++#include > > > + > > > + #include > > > + #include > > > > Could you explain how adding a header file fixes a runtime crash? I could > > guess that it's e.g. because of a missing function prototype that returns > > a pointer or something ... > > Exactly this. Understood. Please try to write more elaborate commit logs next time, so everyone could easily see what's going on, not just you or me. ./danfe