From owner-cvs-ports@FreeBSD.ORG Sun Oct 2 08:30:59 2011 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E17B21065672; Sun, 2 Oct 2011 08:30:59 +0000 (UTC) (envelope-from amurphy@gsoft.com.au) Received: from cain.gsoft.com.au (cain.gsoft.com.au [203.31.81.10]) by mx1.freebsd.org (Postfix) with ESMTP id 2FF5C8FC08; Sun, 2 Oct 2011 08:30:58 +0000 (UTC) Received: from piglet.cheese.dnsalias.net (ppp118-210-166-14.lns20.adl6.internode.on.net [118.210.166.14]) (authenticated bits=0) by cain.gsoft.com.au (8.14.4/8.14.3) with ESMTP id p9282n4B091129 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Sun, 2 Oct 2011 18:32:49 +1030 (CST) (envelope-from amurphy@gsoft.com.au) Message-ID: <4E881AA8.2060509@gsoft.com.au> Date: Sun, 02 Oct 2011 18:32:48 +1030 From: Adrian Murphy User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:7.0) Gecko/20110928 Thunderbird/7.0 MIME-Version: 1.0 To: Mikhail Teterin References: <201109210506.p8L56DFd078754@repoman.freebsd.org> In-Reply-To: <201109210506.p8L56DFd078754@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 2.162 (**) BAYES_00,KHOP_DYNAMIC,RDNS_DYNAMIC X-Scanned-By: MIMEDefang 2.67 on 203.31.81.10 Cc: cvs-ports@freebsd.org Subject: Re: cvs commit: ports/net/minidlna Makefile distinfo pkg-descr ports/net/minidlna/files BSDmakefile patch-2928850 patch-aa patch-conf patch-minidlna.c patch-upnphttp X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Oct 2011 08:31:00 -0000 Hi Mikhail, I found this update to minidlna broke my installation. On 21/09/2011 14:36, Mikhail Teterin wrote: > mi 2011-09-21 05:06:13 UTC > > FreeBSD ports repository > > Modified files: > net/minidlna Makefile distinfo pkg-descr > net/minidlna/files BSDmakefile patch-aa patch-minidlna.c > patch-upnphttp > Added files: > net/minidlna/files patch-conf > Removed files: > net/minidlna/files patch-2928850 > Log: > Upgrade to the latest version from author: 1.0.22 > > Revision Changes Path > 1.4 +5 -6 ports/net/minidlna/Makefile > 1.2 +2 -2 ports/net/minidlna/distinfo > 1.3 +1 -1 ports/net/minidlna/files/BSDmakefile > 1.2 +0 -639 ports/net/minidlna/files/patch-2928850 (dead) > 1.2 +254 -0 ports/net/minidlna/files/patch-aa > 1.1 +13 -0 ports/net/minidlna/files/patch-conf (new) > 1.2 +31 -13 ports/net/minidlna/files/patch-minidlna.c > 1.2 +0 -35 ports/net/minidlna/files/patch-upnphttp > 1.2 +0 -3 ports/net/minidlna/pkg-descr My PC is running FreeBSD 8.2-RELEASE #0: Thu Feb 17 02:41:51 UTC 2011 root@mason.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64 I found that it works normally connecting with my Sony Bravia TV and PS3, but as soon as an iPad2 running iOS 4.3.5 connects with minidlna it would crash. I believe Windows media player cause the same grief. On another i386 PC I tried, I don't experience this problem. With gdb I found the problem was in read_random_bytes in the file uuid.c The port provides the patch file, patch-aa, which defines "long r;" in read_random_bytes, which is 8 bytes on my AMD64 PC. On i386, long takes 4 bytes. I changed the patch file so that "long r" becomes "int r" and this fixes the crash problem. I'm not convinced long -> int is the right way to fix this. What do you think? Thanks for your, and others, work on minidlna. It's awesome for connecting my telly, laptop and iPad to the photos, music and videos on my computer. Regards, Adrian